Skip to content

nixos/greetd: autostart GNOME Keyring when enabled#265536

Merged
Mic92 merged 1 commit intoNixOS:masterfrom
pluiedev:fix/greetd-pam-enable-gnome-keyring
Nov 5, 2023
Merged

nixos/greetd: autostart GNOME Keyring when enabled#265536
Mic92 merged 1 commit intoNixOS:masterfrom
pluiedev:fix/greetd-pam-enable-gnome-keyring

Conversation

@pluiedev
Copy link
Member

@pluiedev pluiedev commented Nov 4, 2023

Description of changes

The PAM service greetd creates now autostarts GNOME Keyring when it is enabled via services.gnome.gnome-keyring.enable.

Should cause a lot fewer headaches for people like me who didn't know why GNOME Keyring was complaining that it was never supplied with login details.

Fixes #246197

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Nov 4, 2023
@pluiedev pluiedev requested a review from queezle42 November 4, 2023 22:21
The PAM service `greetd` creates now autostarts GNOME Keyring when it is
enabled via `services.gnome.gnome-keyring.enable`.

Should cause a lot fewer headaches for people like me who didn't know
why GNOME Keyring was complaining that it was never supplied with login details.

Fixes NixOS#246197
@pluiedev pluiedev force-pushed the fix/greetd-pam-enable-gnome-keyring branch from 3d9a31d to cd87f5d Compare November 4, 2023 22:25
@pluiedev pluiedev changed the title fix(nixos/greetd): autostart GNOME Keyring when enabled nixos/greetd: autostart GNOME Keyring when enabled Nov 4, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Nov 5, 2023
@Mic92 Mic92 merged commit 30f2f95 into NixOS:master Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow unlocking of keyring from greetd

2 participants