Skip to content

nixos/systemd-boot: add JulienMalka as maintainer#265281

Merged
RaitoBezarius merged 1 commit intoNixOS:masterfrom
JulienMalka:systemd-boot-maintainer
Nov 5, 2023
Merged

nixos/systemd-boot: add JulienMalka as maintainer#265281
RaitoBezarius merged 1 commit intoNixOS:masterfrom
JulienMalka:systemd-boot-maintainer

Conversation

@JulienMalka
Copy link
Member

Description of changes

I am willing to take shared or total responsibility (depending on the current state of things) of the maintenance of the systemd-boot module. My work these last few weeks has helped my have a clear view of the current codebase for the modules and the tests.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: policy discussion Discuss policies to work in and around Nixpkgs labels Nov 3, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Nov 3, 2023
@JulienMalka
Copy link
Member Author

Apparently the codeowner change is not valid I believe because I am not a committer.

@RaitoBezarius
Copy link
Member

Yep, but it's fine to start as a maintainer. As we fix ofborg, this will work out fine!

1 similar comment
@RaitoBezarius
Copy link
Member

Yep, but it's fine to start as a maintainer. As we fix ofborg, this will work out fine!

@github-actions github-actions bot removed the 6.topic: policy discussion Discuss policies to work in and around Nixpkgs label Nov 4, 2023
@JulienMalka
Copy link
Member Author

Apparently the codeowner change is not valid I believe because I am not a committer.

I removed the change to the codeowners

@RaitoBezarius RaitoBezarius merged commit 0020a3f into NixOS:master Nov 5, 2023
@JulienMalka JulienMalka deleted the systemd-boot-maintainer branch November 5, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants