Skip to content

Comments

bazel: use bash with fallback $PATH consisting of basic shell utils#265041

Merged
bjornfor merged 1 commit intoNixOS:masterfrom
malt3:fix/bazel/bashWithUtils
Nov 10, 2023
Merged

bazel: use bash with fallback $PATH consisting of basic shell utils#265041
bjornfor merged 1 commit intoNixOS:masterfrom
malt3:fix/bazel/bashWithUtils

Conversation

@malt3
Copy link
Contributor

@malt3 malt3 commented Nov 2, 2023

Description of changes

Fixes #265040. Ensure any shell action has a minimal set of tools available (even for remote builds).

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Nov 2, 2023
uri-canva
uri-canva approved these changes Nov 5, 2023
View reviewed changes
Copy link
Contributor

@uri-canva uri-canva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds ok to me.

olebedev
olebedev approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@olebedev olebedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@malt3 malt3 marked this pull request as ready for review November 6, 2023 06:04
@malt3 malt3 requested a review from Profpatsch as a code owner November 6, 2023 06:05
@delroth delroth added 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Nov 6, 2023
@bjornfor bjornfor merged commit 3576806 into NixOS:master Nov 10, 2023
@malt3 malt3 deleted the fix/bazel/bashWithUtils branch November 10, 2023 23:53
@mweinelt
Copy link
Member

mweinelt commented Nov 11, 2023

Bisect thinks this change broke python311.pkgs.jaxlib.

3576806d7edc615b2e89ee4f845d67c5b6c7ecc1 is the first bad commit
commit 3576806d7edc615b2e89ee4f845d67c5b6c7ecc1
Author: Malte Poll <[email protected]>
Date:   Thu Nov 2 13:13:00 2023 +0100

    bazel: use bash with fallback $PATH consisting of basic shell utils

 .../tools/build-managers/bazel/bazel_6/default.nix  | 21 ++++++++++++++++-----
 1 file changed, 16 insertions(+), 5 deletions(-)
bisect found first bad commit

bazel-build-jaxlib> building '/nix/store/dap85k2hizfk5wyg9qxcr95w06ig3307-bazel-build-jaxlib-0.4.19.drv'
bazel-build-jaxlib> unpacking sources
bazel-build-jaxlib> unpacking source archive /nix/store/j4bkh2nlm62pjxp7is00g2bcp608xb2b-source
bazel-build-jaxlib> source root is source
bazel-build-jaxlib> patching sources
bazel-build-jaxlib> updateAutotoolsGnuConfigScriptsPhase
bazel-build-jaxlib> configuring
bazel-build-jaxlib> no configure script, doing nothing
bazel-build-jaxlib> building
bazel-build-jaxlib> Extracting Bazel installation...
bazel-build-jaxlib> INFO: Options provided by the client:
bazel-build-jaxlib>   Inherited 'common' options: --isatty=1 --terminal_columns=0
bazel-build-jaxlib> INFO: Reading rc options for 'run' from /build/source/.bazelrc:
bazel-build-jaxlib>   Inherited 'common' options: --experimental_repo_remote_exec
bazel-build-jaxlib> INFO: Reading rc options for 'run' from /nix/store/v9x5zmj6ai0c5vjiv4yfjb0nqafiiga2-bazel-rc:
bazel-build-jaxlib>   Inherited 'build' options: --distdir=/nix/store/m8y1s64j25am1b60ihzk11wprr2wmjra-bazel-deps --extra_toolchains=@bazel_tools//tools/jdk:nonprebuilt_toolchain_definition --tool_java_runtime_version=local_jdk_11 --java_runtime_version=local_jdk_11
bazel-build-jaxlib> INFO: Reading rc options for 'run' from /build/source/.bazelrc:
bazel-build-jaxlib>   Inherited 'build' options: --nocheck_visibility --apple_platform_type=macos --macos_minimum_os=10.14 --announce_rc --define open_source_build=true --spawn_strategy=standalone --enable_platform_specific_config --experimental_cc_shared_library --define=no_aws_support=true --define=no_gcp_support=true --define=no_hdfs_support=true --define=no_kafka_support=true --define=no_ignite_support=true --define=grpc_no_ares=true --define=tsl_link_protobuf=true -c opt --config=short_logs --copt=-DMLIR_PYTHON_PACKAGE_PREFIX=jaxlib.mlir. --@xla//xla/python:enable_gpu=false
bazel-build-jaxlib> INFO: Reading rc options for 'run' from /build/source/.jax_configure.bazelrc:
bazel-build-jaxlib>   Inherited 'build' options: --strategy=Genrule=standalone --repo_env PYTHON_BIN_PATH=/nix/store/ffll6glz3gwx342z0ch8wx30p5cnqz1z-python3-3.11.5/bin/python --action_env=PYENV_ROOT --python_path=/nix/store/ffll6glz3gwx342z0ch8wx30p5cnqz1z-python3-3.11.5/bin/python --distinct_host_configuration=false --define PROTOBUF_INCLUDE_PATH=/nix/store/5prkzfpsimriksa691j4ip7w90gn4ca7-protobuf-3.24.3/include --config=mkl_open_source_only
bazel-build-jaxlib> INFO: Found applicable config definition build:short_logs in file /build/source/.bazelrc: --output_filter=DONT_MATCH_ANYTHING
bazel-build-jaxlib> INFO: Found applicable config definition build:mkl_open_source_only in file /build/source/.bazelrc: --define=tensorflow_mkldnn_contraction_kernel=1
bazel-build-jaxlib> INFO: Found applicable config definition build:linux in file /build/source/.bazelrc: --config=posix --copt=-Wno-unknown-warning-option --copt=-Wno-stringop-truncation --copt=-Wno-array-parameter
bazel-build-jaxlib> INFO: Found applicable config definition build:posix in file /build/source/.bazelrc: --copt=-fvisibility=hidden --copt=-Wno-sign-compare --cxxopt=-std=c++17 --host_cxxopt=-std=c++17
bazel-build-jaxlib> Loading: 
bazel-build-jaxlib> DEBUG: /build/output/external/xla/third_party/repo.bzl:132:14: 
bazel-build-jaxlib> Warning: skipping import of repository 'llvm-raw' because it already exists.
bazel-build-jaxlib> Loading: 
bazel-build-jaxlib> Loading: 1 packages loaded
bazel-build-jaxlib> Analyzing: target //jaxlib/tools:build_wheel (2 packages loaded, 0 targets configured)
bazel-build-jaxlib> Analyzing: target //jaxlib/tools:build_wheel (65 packages loaded, 392 targets configured)
bazel-build-jaxlib> Analyzing: target //jaxlib/tools:build_wheel (189 packages loaded, 8992 targets configured)
bazel-build-jaxlib> INFO: Analyzed target //jaxlib/tools:build_wheel (200 packages loaded, 13198 targets configured).
bazel-build-jaxlib> INFO: Found 1 target...
bazel-build-jaxlib> [0 / 20] [Prepa] BazelWorkspaceStatusAction stable-status.txt ... (2 actions, 1 running)
bazel-build-jaxlib> ERROR: /build/output/external/local_config_python/BUILD:78:8: Executing genrule @local_config_python//:python_include failed: (Exit 1): bash failed: error executing command (from target @local_config_python//:python_include) /nix/store/j2l90z41r5c85zpfbj91dsxycm6mm8s9-bash/bin/bash -c ... (remaining 1 argument skipped)
bazel-build-jaxlib> src/main/tools/process-wrapper-legacy.cc:80: "execvp(/nix/store/j2l90z41r5c85zpfbj91dsxycm6mm8s9-bash/bin/bash, ...)": No such file or directory
bazel-build-jaxlib> ERROR: /build/output/external/xla/third_party/py/numpy/BUILD:16:8: Executing genrule @xla//third_party/py/numpy:dummy failed: (Exit 1): bash failed: error executing command (from target @xla//third_party/py/numpy:dummy) /nix/store/j2l90z41r5c85zpfbj91dsxycm6mm8s9-bash/bin/bash -c 'source external/bazel_tools/tools/genrule/genrule-setup.sh; touch bazel-out/k8-opt/bin/external/xla/third_party/py/numpy/tf_numpy_dummy.py'
bazel-build-jaxlib> src/main/tools/process-wrapper-legacy.cc:80: "execvp(/nix/store/j2l90z41r5c85zpfbj91dsxycm6mm8s9-bash/bin/bash, ...)": No such file or directory
bazel-build-jaxlib> Target //jaxlib/tools:build_wheel failed to build
bazel-build-jaxlib> Use --verbose_failures to see the command lines of failed build steps.
bazel-build-jaxlib> INFO: Elapsed time: 4.378s, Critical Path: 0.03s
bazel-build-jaxlib> INFO: 57 processes: 57 internal.
bazel-build-jaxlib> FAILED: Build did NOT complete successfully
bazel-build-jaxlib> ERROR: Build failed. Not running target
bazel-build-jaxlib> 
error: builder for '/nix/store/dap85k2hizfk5wyg9qxcr95w06ig3307-bazel-build-jaxlib-0.4.19.drv' failed with exit code 1;

@mweinelt mweinelt mentioned this pull request Nov 11, 2023
Merged
13 tasks
@bjornfor bjornfor mentioned this pull request Nov 11, 2023
Merged
13 tasks
@bjornfor
Copy link
Contributor

bjornfor commented Nov 11, 2023

Revert PR here: #266842

mweinelt pushed a commit that referenced this pull request Nov 11, 2023
@bjornfor
Revert "bazel: use bash with fallback $PATH consisting of basic shell…
7e41495 
… utils"

This reverts commit 3576806.

It broke python311.pkgs.jaxlib, see
#265041 (comment).
@uri-canva uri-canva mentioned this pull request Nov 11, 2023
Closed
@malt3
Copy link
Contributor Author

malt3 commented Nov 11, 2023 •
edited
Loading

bazel-build-jaxlib> src/main/tools/process-wrapper-legacy.cc:80: "execvp(/nix/store/j2l90z41r5c85zpfbj91dsxycm6mm8s9-bash/bin/bash, ...)": No such file or directory

I'm pretty sure this is my bashWithDefaultShellUtils. I forgot properly add it as a buildInput of Bazel so it wasn't guaranteed to be available at runtime when bazel is used to build other derivations.

@malt3 malt3 mentioned this pull request Nov 11, 2023
Merged
13 tasks
@natsukium natsukium mentioned this pull request Nov 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marsam marsam Awaiting requested review from marsam

@avdv avdv Awaiting requested review from avdv

@aherrmann aherrmann Awaiting requested review from aherrmann

@groodt groodt Awaiting requested review from groodt

@mboes mboes Awaiting requested review from mboes

@ylecornec ylecornec Awaiting requested review from ylecornec

@Profpatsch Profpatsch Awaiting requested review from Profpatsch

2 more reviewers

@olebedev olebedev olebedev approved these changes

@uri-canva uri-canva uri-canva approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bazel cannot be used for remote builds

6 participants

@malt3 @mweinelt @bjornfor @olebedev @uri-canva @delroth