ripgrep-all: 0.9.6 -> 1.0.0-alpha.5 #264362
Conversation
|
Result of 1 package built:
Tested the resulted binary against the files in |
delroth
added
the
12.approvals: 1
ofborg
bot
added
10.rebuild-darwin: 1-10
magnetophon
left a comment
magnetophon
left a comment
There was a problem hiding this comment.
Result of nixpkgs-review pr 264362 run on x86_64-linux 1
1 package built:
- ripgrep-all
rga and rga-fzf work as expected, but there are also two binaries in /bin dir that I didn't recognize and seem to be "internal" tools:
rga-fzf-open and rga-preproc.
Not sure if they should be in /bin.
|
Yes, they are used internally. Afaik rga expects them to be in the same location the rga binary is |
delroth
added
12.approvals: 2
delroth
added
12.approvals: 3+
|
I can take a look later today and merge if everything seems OK :) |
Ma27
left a comment
Ma27
left a comment
There was a problem hiding this comment.
Tested for a while, also with larger directories and it seems fine so far. The only issue I encountered was that poppler complained about a locked database which could be solved by deleting my old cache (phiresky/ripgrep-all#188), but given that clearing the cache as workaround is sufficient (and there seem to be quite a lot of changes), I'm fine with that.
The author claims that it's working fine for them and should generally be releasable, but they'd like to see if more problems come up. To me the current state seems good enough and the implementation in this PR is IMHO highly preferable over applying all the patches between 0.9.6 and now that fix known issues with adapters without the more complex changes that were the reason for a new major (which is the only other option left short of marking this as broken).
7 participants
Fixes #250306
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)