chromium: do not set snapshot toolchain for native builds#264326
Conversation
ghost
mentioned this pull request
4 tasks
ofborg
bot
added
10.rebuild-darwin: 0
emilylange
requested changes
Nov 3, 2023
Member
emilylange
left a comment
emilylange
left a comment
There was a problem hiding this comment.
Thanks!
I've built the new chromium 119.0.6045.105 (x86_64-linux non-cross) on top of this successfully (~59k steps).
Not quite there yet, but reasonably close to be pre-cross levels.
| @@ -370,7 +370,10 @@ let | |||
| # https://github.com/chromium/chromium/blob/d36462cc9279464395aea5e65d0893d76444a296/build/config/BUILDCONFIG.gn#L17-L44 | |||
| custom_toolchain = "//build/toolchain/linux/unbundle:default"; | |||
| host_toolchain = "//build/toolchain/linux/unbundle:host"; | |||
Member
There was a problem hiding this comment.
Why do we keep
host_toolchain = "//build/toolchain/linux/unbundle:host";
#229265 changed this from :default to :host.
And reverting this to :default for non-cross builds removes another ~4k build steps.
Suggested change
| host_toolchain = "//build/toolchain/linux/unbundle:host"; | |
| host_toolchain = "//build/toolchain/linux/unbundle:default"; |
This was referenced Dec 6, 2023
Merged
Member
|
Superseded by the now merged #273435. |
ghost
deleted the
pr/chromium/dont-set-snapshot-chain-for-native-builds
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
#229265 (comment)
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)