systemd domainname unit - use nix store path of net tools for domainname #264082
Merged
nikstur merged 1 commit intoNixOS:masterfrom Oct 29, 2023
Merged
systemd domainname unit - use nix store path of net tools for domainname #264082nikstur merged 1 commit intoNixOS:masterfrom
net tools for domainname #264082nikstur merged 1 commit intoNixOS:masterfrom
Conversation
needs nettools in path
github-actions
bot
added
6.topic: nixos
ofborg
bot
added
10.rebuild-darwin: 0
nikstur
approved these changes
Oct 29, 2023
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Recent change to how
domainnameis set (going from activationScript to systemd unit) causes an error when trying to activate the systemd unit file - gettingdomainname.service: Failed at step EXEC spawning domainname: No such file or directory.Fixed by adding full path to
nettoolsto the command (ieserviceConfig.ExecStart = ''${pkgs.nettools}/bin/domainname "${cfg.domain}"'';). Suspect this may be an issue in some other places where activationScripts (which seem to inherit the system's installed packages) have been replaced with systemd unit files (which are isolated and do not inherit from $PATH or installed packages)Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)