python311Packages.pydbus: patch python311 compat#263669
Merged
mweinelt merged 2 commits intoNixOS:masterfrom Oct 27, 2023
Merged
python311Packages.pydbus: patch python311 compat#263669mweinelt merged 2 commits intoNixOS:masterfrom
mweinelt merged 2 commits intoNixOS:masterfrom
Conversation
The package has not been updated since 2018 and has been running into removals on python311. Fortunately getfullargspec is a drop-in replacement for getargspec, so a simple substitution restore life support for now.
mweinelt
force-pushed
the
pydbus-lifesupport
branch
from
063f6b9 to
0ec908a
Compare
github-actions
bot
added
the
6.topic: python
ofborg
bot
added
8.has: package (new)
Member
Author
|
Result of 4 packages failed to build:
24 packages built:
|
13 tasks
13 tasks
adisbladis
reviewed
Oct 30, 2023
| buildPythonPackage rec { | ||
| pname = "pydbus"; | ||
| version = "0.6.0"; | ||
| pyproejct = true; |
Member
There was a problem hiding this comment.
Minor spelling mistake: pyproejct -> pyproject.
13 tasks
ghost
mentioned this pull request
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The package has not been updated since 2018 and has been running into removals on python311.
Fortunately getfullargspec is a drop-in replacement for getargspec, so a simple substitution restore life support for now.
cc #263657
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)