Skip to content

pantalaimon: fix breaking python 3.11 build#263657

Closed
Icy-Thought wants to merge 1 commit intoNixOS:masterfrom
Icy-Thought:pantalaimon
Closed

pantalaimon: fix breaking python 3.11 build#263657
Icy-Thought wants to merge 1 commit intoNixOS:masterfrom
Icy-Thought:pantalaimon

Conversation

@Icy-Thought
Copy link
Contributor

@Icy-Thought Icy-Thought commented Oct 26, 2023

Description of changes

Current pantalaimon package breaks when attempting to build the package with Python 3.11. Therefore I choose to limit the package build to Python 3.10 for it to continue building as expected.

Build Error
error: pydbus-0.6.0 not supported for interpreter python3.11

The solution I came up with might not be good, therefore I'd welcome any form of packaging suggestions if you have one to share!

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@mweinelt
Copy link
Member

Please report the failing dependency upstream to pantalaimon. They probably don't want to use a library that was last updated over 5 years ago.

@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Oct 27, 2023
@Icy-Thought
Copy link
Contributor Author

Just created an issue in the pantalaimon repository mentioning a search for a pydbus replacement in matrix-org/pantalaimon#162. Any input would be appreciated!

@mweinelt
Copy link
Member

Note that I unbroke pydbus for python3.11 in #263669, so the motivation for this PR should be resolved.

@Icy-Thought
Copy link
Contributor Author

Guess we can close this issue since it's no longer needed!
Appreciate the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants