python3.pkgs.meson-python: run hook in postConfigure#260637
Merged
vcunat merged 1 commit intoNixOS:staging-nextfrom Oct 14, 2023
Merged
python3.pkgs.meson-python: run hook in postConfigure#260637vcunat merged 1 commit intoNixOS:staging-nextfrom
vcunat merged 1 commit intoNixOS:staging-nextfrom
Conversation
github-actions
bot
added
the
6.topic: python
ofborg
bot
added
10.rebuild-darwin: 501+
Contributor
|
Looks good, have you tested cross compilation of something with this? Maybe of |
Member
Author
|
Tested cross-compilation of scipy; seems to work fine. |
Member
Author
|
@vcunat can we get this into staging-next still? It's a fix for a commit in master. |
Member
|
Anything really is OK rebuild-wise right now. So the only possible problem is likelihood of creating some regressions, as the current |
Member
Author
|
I think this should be pretty safe — only a handful of packages actually use this hook, and I've built them all successfully. |
It's not uncommon for packages to modify mesonFlags/mesonFlagsArray in e.g. preConfigure. Since the hook was previously run immediately, these changes wouldn't have been picked up. To fix this, run the hook after the configure phase, where we know the list of meson flags will have been finalized. Fixes: 70d182b ("python3.pkgs.meson-python: populate python build flags with $mesonFlags")
alyssais
force-pushed
the
meson-python-postConfigure
branch
from
7e45d40 to
787af71
Compare
Member
Author
|
@doronbehar btw, this should probably support |
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
It's not uncommon for packages to modify mesonFlags/mesonFlagsArray in e.g. preConfigure. Since the hook was previously run immediately, these changes wouldn't have been picked up. To fix this, run the hook after the configure phase, where we know the list of meson flags will have been finalized.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)