llvmPackages.llvm: propagate deps to nativeCC in cross build#260543
Draft
reckenrode wants to merge 12 commits intoNixOS:masterfrom
Draft
llvmPackages.llvm: propagate deps to nativeCC in cross build#260543reckenrode wants to merge 12 commits intoNixOS:masterfrom
reckenrode wants to merge 12 commits intoNixOS:masterfrom
Conversation
13 tasks
ofborg
bot
added
6.topic: cross-compilation
12 tasks
wegank
added
the
2.status: merge conflict
rrbutani
added
the
6.topic: llvm/clang
wegank
added
the
2.status: stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Cross-compiling LLVM fails on Darwin because it cannot link libc++abi. This is because the native compiler’s dependencies are not propagated as expected. This PR propagates them manually for nativeCC when cross-compiling.
Note that x86_64-darwin to aarch64-darwin cross can be tested on master, but aarch64-darwin to x86_64-darwin cross requires #256590.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)