Skip to content

curl: 8.3.0 -> 8.4.0#260378

Merged
lheckemann merged 1 commit intoNixOS:staging-nextfrom
999eagle:feat/curl
Oct 12, 2023
Merged

curl: 8.3.0 -> 8.4.0#260378
lheckemann merged 1 commit intoNixOS:staging-nextfrom
999eagle:feat/curl

Conversation

@999eagle
Copy link
Contributor

@999eagle 999eagle commented Oct 11, 2023 •
edited by mweinelt
Loading

Description of changes

https://daniel.haxx.se/blog/2023/10/11/curl-8-4-0/

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@999eagle 999eagle changed the base branch from master to staging October 11, 2023 06:44
@999eagle 999eagle added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Oct 11, 2023
@oxalica
Copy link
Contributor

oxalica commented Oct 11, 2023

Should this go master instead of staging since it's a "critical security fix"?

@oxalica oxalica mentioned this pull request Oct 11, 2023
Closed
@999eagle
Copy link
Contributor Author

999eagle commented Oct 11, 2023 •
edited
Loading

The current staging-next cycle is explicitly waiting for this update to be included there: #257792 (comment)

@ofborg ofborg bot added the 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. label Oct 11, 2023
@ofborg ofborg bot requested a review from lovek323 October 11, 2023 08:17
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Oct 11, 2023
@vcunat vcunat changed the base branch from staging to staging-next October 12, 2023 07:17
@lheckemann lheckemann merged commit 75db88e into NixOS:staging-next Oct 12, 2023
@vcunat
Copy link
Member

vcunat commented Oct 13, 2023 •
edited
Loading

This is quite a problem on darwin. If noone resolves the cascade of breakages by the time Hydra has (darwin?) resources to work on this, I'll revert and take just the patch for now, like on 23.05. (EDIT: maaaybe a darwin-only revert.)

Some discussion was at #257792 (comment)
/cc @NixOS/darwin-maintainers

@vcunat
Copy link
Member

vcunat commented Oct 13, 2023

We might temporarily revert curl/curl@6ab7e19 or something. The issue is in cyclic dependency on CoreServices from stdenv bootstrapping.

@vcunat vcunat mentioned this pull request Oct 13, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lovek323 lovek323 Awaiting requested review from lovek323

1 more reviewer

@lheckemann lheckemann lheckemann approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@999eagle @oxalica @vcunat @lheckemann