Merged
Conversation
ofborg
bot
added
8.has: package (new)
BenediktBroich
force-pushed
the
audio-sharing
branch
from
f02e106 to
cdce203
Compare
linsui
reviewed
Oct 9, 2023
Contributor
|
It still doesn't work for me. It says No audio sink found. |
BenediktBroich
force-pushed
the
audio-sharing
branch
2 times, most recently
from
b78c5c9 to
2c9737f
Compare
Contributor
Author
True. Dependency pulsesrc was missing. Now you can test again if you want to. |
Contributor
|
Still the same error. |
Contributor
Author
|
Result of 1 package built:
|
Contributor
Author
|
@linsui What sound config do you have on your system?
|
Contributor
pipewire = {
enable = true;
alsa.enable = true;
alsa.support32Bit = true;
pulse.enable = true;
}; |
Contributor
Author
Contributor
|
Ah, that's sad... Yes, after switching to pipewire audio sharing can't find sink anymore. Though it didn't work for me with pulseaudio, either. |
Contributor
Author
|
@linsui Did you build it using nix-build or nixpkgs-review? |
Contributor
|
I build it with nix-build. |
BenediktBroich
force-pushed
the
audio-sharing
branch
from
2c9737f to
7324505
Compare
Contributor
Author
|
Can you run |
Contributor
|
Nothing changed. By the way, nixpkgs-review is really slow... |
Contributor
Author
|
Can you post the nix-build output? |
Contributor
|
The log or the file? |
Contributor
Author
|
Just the terminal output of the |
Contributor
Contributor
Author
|
I don't see an Issue. Maybe somene else can test it first, to confirm this. |
31 tasks
Contributor
|
The test works for me. My audio config (excluding bluetooth stuff): hardware.pulseaudio.enable = false;
services.pipewire = {
enable = true;
audio.enable = true;
# Support alsa programs
alsa.enable = true;
alsa.support32Bit = true;
# Support pulseaudio programs
pulse.enable = true;
# Support JACK programs
jack.enable = true;
}; |
Contributor
|
Result of 1 package built:
|
Contributor
|
I ran Here's my audio config and the build log: sound.enable = true;
hardware.pulseaudio.enable = false;
security.rtkit.enable = true;
services.pipewire = {
enable = true;
alsa.enable = true;
alsa.support32Bit = true;
pulse.enable = true;
jack.enable = true;
}; |
Contributor
|
Also note, the flatpak version of this app does not have this issue on my system. |
Contributor
|
@gaykitty Why are you enabling ALSA ( |
Contributor
|
I seems that it uses gstreamer for getting the audio but I failed to find out which audio servers it supports. |
Contributor
|
dafuq… I tried to find out which sound servers you need by enabling and disabling the pipewire plugins but I found out that you need both the alsa and pulseaudio emulation. |
Contributor
tbh idk. That part of my config has been there since I first started using nixos. I think I just copied it from someone. |
Contributor
|
@gaykitty does it work without? |
Contributor
|
Removing |
Contributor
|
@gaykitty so you have the same audio config as me but it doesn't work? Confused… |
Contributor
|
If you're config is: hardware.pulseaudio.enable = false;
security.rtkit.enable = true;
services.pipewire = {
enable = true;
alsa.enable = true;
alsa.support32Bit = true
pulse.enable = true;
jack.enable = true;
};Then yes. |
Contributor
|
yes, that's it. |
Contributor
|
maybe some other config options have an effect on this? |
Contributor
Author
|
Result of 1 package built:
For me it is still working, on unstabe |
Contributor
|
Works for me with a similar config to #259976 (comment) (without jack). I'm not sure I like merging it with a very unclear reason for why it does or doesn't work for different people, seeing as there's complaints on both pulse and pipewire, but not enough for me to take a guess at a repro case and debugging myself. @BenediktBroich regardless of the above, this should be following the by-name scheme now before it can be merged. |
BenediktBroich
force-pushed
the
audio-sharing
branch
from
7324505 to
190c563
Compare
BenediktBroich
force-pushed
the
audio-sharing
branch
from
190c563 to
c30db09
Compare
Contributor
Author
|
The application is using gst_all_1. And it is only supposed to work with pulseaudio pulsesrc (here). It will only work with pipewire when backwards the compatiblity is enabled @amaxine So i would propose to merge this Package and i will have a lookout for Issues tagging audio-sharing to further debug this. Otherwise i think we will not get much feedback on this. I think it is not a bug in this Application. It is caused by the Audio configuration or user permissions of the user. |
Contributor
|
Good point. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Application for sharing audio in you network (rtsp).
Test
audio-sharempv <LINK>now you should hear the audioSrc: AudioSharing
Issue: #195280
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)