Skip to content

fetchurl: use certificate from NIX_SSL_CERT_FILE#259179

Closed
linsui wants to merge 1 commit intoNixOS:masterfrom
linsui:cert-fetchurl
Closed

fetchurl: use certificate from NIX_SSL_CERT_FILE#259179
linsui wants to merge 1 commit intoNixOS:masterfrom
linsui:cert-fetchurl

Conversation

@linsui
Copy link
Contributor

@linsui linsui commented Oct 5, 2023

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: fetch Fetchers (e.g. fetchgit, fetchsvn, ...) label Oct 5, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Oct 5, 2023
@timbertson
Copy link
Contributor

This makes sense to me, see also NixOS/nix#5837

Copy link
Contributor

@3noch 3noch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash commits.

@3noch
Copy link
Contributor

3noch commented Jun 26, 2024

Related: #303307

Update pkgs/build-support/fetchurl/builder.sh

Co-authored-by: Sandro <[email protected]>
@linsui linsui requested a review from philiptaron as a code owner August 21, 2024 03:11
@linsui linsui closed this Aug 24, 2024
@linsui linsui deleted the cert-fetchurl branch November 28, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: fetch Fetchers (e.g. fetchgit, fetchsvn, ...) 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants