onnxruntime: 1.15.1 -> 1.16.3 by cbourjau · Pull Request #258392 · NixOS/nixpkgs

cbourjau · 2023-10-01T12:35:10Z

Description of changes

Regular update to the latest version. Release notes: https://github.com/microsoft/onnxruntime/releases/tag/v1.16.3

Things done

cbourjau · 2023-10-02T06:20:24Z

Running nixpkgs-review on x86_64-linux on this PR triggers the build error described here: #251132 (comment)

Zahrun · 2024-01-13T02:51:23Z

ONNX Runtime v1.16.3 came out

cbourjau · 2024-01-15T00:43:42Z

I updated this PR. The ONNX ecosystem on nixpkgs (or one may say in general) is in a bit of disarray. It seems unlikely to get everything to build with a single PR. I'd love some feedback on how to proceed!

pkgs/development/libraries/onnxruntime/default.nix

Zahrun · 2024-01-17T04:57:55Z

Related #281011 (comment)

Scrumplex · 2024-01-20T00:33:06Z

Result of nixpkgs-review pr 258392 run on x86_64-linux 1

4 packages marked as broken and skipped:

piper-train
piper-train.dist
python312Packages.onnxruntime
python312Packages.onnxruntime.dist

6 packages failed to build:

python311Packages.fastembed
python311Packages.fastembed.dist
python311Packages.mmcv
python311Packages.mmcv.dist
python311Packages.tf2onnx
python311Packages.tf2onnx.dist

24 packages built:

aitrack
deface
deface.dist
livecaptions
monado
obs-studio-plugins.obs-backgroundremoval
onnxruntime
onnxruntime.dev
onnxruntime.dist
opencomposite-helper
piper-phonemize
piper-tts
python311Packages.faster-whisper
python311Packages.faster-whisper.dist
python311Packages.insightface
python311Packages.insightface.dist
python311Packages.onnxruntime
python311Packages.onnxruntime.dist
python311Packages.piper-phonemize
python311Packages.piper-phonemize.dist
python312Packages.piper-phonemize
python312Packages.piper-phonemize.dist
whisper-ctranslate2
whisper-ctranslate2.dist

Scrumplex · 2024-01-20T00:34:04Z

error: builder for '/nix/store/kzdxv2ns7qq1dsbr30wj4n9yq2j8j699-python3.11-fastembed-0.1.2.drv' failed with exit code 1;
       last 10 log lines:
       > * Getting build dependencies for wheel...
       > * Building wheel...
       > Successfully built fastembed-0.1.1-py3-none-any.whl
       > Finished creating a wheel...
       > Finished executing pypaBuildPhase
       > Running phase: pythonRuntimeDepsCheckHook
       > Executing pythonRuntimeDepsCheck
       > Checking runtime dependencies for fastembed-0.1.1-py3-none-any.whl
       >   - huggingface-hub not installed
       >   - onnx not installed
       For full logs, run 'nix log /nix/store/kzdxv2ns7qq1dsbr30wj4n9yq2j8j699-python3.11-fastembed-0.1.2.drv'.
error: builder for '/nix/store/dqpzmjmmd4pwd9d6kqwsjjxgylgsmwch-python3.11-tf2onnx-1.15.1.drv' failed with exit code 1;
       last 10 log lines:
       > Executing pythonRemoveTestsDir
       > Finished executing pythonRemoveTestsDir
       > Running phase: installCheckPhase
       > no Makefile or custom installCheckPhase, doing nothing
       > Running phase: pythonCatchConflictsPhase
       > Found duplicated packages in closure for dependency 'protobuf':
       >        protobuf 4.24.4 (/nix/store/gknbg49nip7j60a53ch5g1b0hbxvqrhi-python3.11-protobuf-4.24.4/lib/python3.11/site-packages/protobuf-4.24.4.dist-info)
       >        protobuf 4.21.12 (/nix/store/fpcpf3fs5dbn0g3inkm2gl1zxk13d123-python3.11-protobuf-4.21.12/lib/python3.11/site-packages/protobuf-4.21.12.dist-info)
       >
       > Package duplicates found in closure, see above. Usually this happens if two packages depend on different version of the same dependency.
       For full logs, run 'nix log /nix/store/dqpzmjmmd4pwd9d6kqwsjjxgylgsmwch-python3.11-tf2onnx-1.15.1.drv'.

These are all unrelated to this PR I'd say

Scrumplex · 2024-01-20T00:34:39Z

I mentioned in the other PR before that I had test failures before. I wonder if updating googletest made them go away magically?

cbourjau · 2024-01-21T00:12:19Z

The gtest update was not necessary. I removed that part. But it is good to know that it will also work with 1.14. Once the nixpkgs version is up-to-date (PR) we can use that instead.

cbourjau · 2024-01-21T10:13:48Z

Result of nixpkgs-review pr 258392 run on aarch64-darwin 1

4 packages marked as broken and skipped:

python311Packages.tf2onnx
python311Packages.tf2onnx.dist
python312Packages.onnxruntime
python312Packages.onnxruntime.dist

4 packages failed to build:

python311Packages.fastembed
python311Packages.fastembed.dist
python311Packages.mmcv
python311Packages.mmcv.dist

15 packages built:

deface
deface.dist
onnxruntime
onnxruntime.dev
onnxruntime.dist
piper-phonemize
piper-tts
python311Packages.insightface
python311Packages.insightface.dist
python311Packages.onnxruntime
python311Packages.onnxruntime.dist
python311Packages.piper-phonemize
python311Packages.piper-phonemize.dist
python312Packages.piper-phonemize
python312Packages.piper-phonemize.dist

Scrumplex · 2024-01-21T11:14:19Z

Result of nixpkgs-review pr 258392 run on x86_64-linux 1

4 packages marked as broken and skipped:

piper-train
piper-train.dist
python312Packages.onnxruntime
python312Packages.onnxruntime.dist

6 packages failed to build:

python311Packages.fastembed
python311Packages.fastembed.dist
python311Packages.mmcv
python311Packages.mmcv.dist
python311Packages.tf2onnx
python311Packages.tf2onnx.dist

24 packages built:

aitrack
deface
deface.dist
livecaptions
monado
obs-studio-plugins.obs-backgroundremoval
onnxruntime
onnxruntime.dev
onnxruntime.dist
opencomposite-helper
piper-phonemize
piper-tts
python311Packages.faster-whisper
python311Packages.faster-whisper.dist
python311Packages.insightface
python311Packages.insightface.dist
python311Packages.onnxruntime
python311Packages.onnxruntime.dist
python311Packages.piper-phonemize
python311Packages.piper-phonemize.dist
python312Packages.piper-phonemize
python312Packages.piper-phonemize.dist
whisper-ctranslate2
whisper-ctranslate2.dist

pinpox · 2024-01-23T09:01:48Z

What needs to be done to get this fixed? onnxruntime build failiure is preventing my system from building, anything I can help with? In case we have to wait still, is it possible to override nixpkgs to fix it somehow?

pkgs/development/libraries/onnxruntime/default.nix

cbourjau · 2024-02-07T12:04:53Z

Please note that onnxruntime 1.17.0 has been released in the meantime. Some of the dependencies were (aggressively) updated and the build is yet again not trivial for a nix beginner like me. Unfortunately, I don't currently have the time to push this PR over the finish line.

spikespaz · 2024-02-07T15:51:05Z

Can't this PR be finished, and we can just point a finger at Microsoft?

mweinelt · 2024-02-07T16:28:42Z

I looked into the open reviews and addressed most/all of them. I think we should get a working version in before thinking about 1.17.0.

https://github.com/microsoft/onnxruntime/releases/tag/v1.16.1 https://github.com/microsoft/onnxruntime/releases/tag/v1.16.2 https://github.com/microsoft/onnxruntime/releases/tag/v1.16.3

mweinelt · 2024-02-07T17:00:12Z

I decided to just fetch the eigen version that they pinned, instead of relying on a patched version of our source. At some point someone should try and use as many system dependencies as possible.

https://git.alpinelinux.org/aports/tree/testing/onnxruntime?h=master
- system.patch
https://gitlab.archlinux.org/archlinux/packaging/packages/onnxruntime
- onnxruntime-system-dnnl.patch
- onnxruntime-system-flatbuffers.patch

SomeoneSerge

I'm trying to build this with the FIND_PACKAGE_ARGS patch (and without patching eigen at all), so far at 94% without errors. Waiting

EDIT: Yup, it just works, no patching seems to be needed. Or are we expecting a runtime error?

Uhm, I don't know which ref should I push to to update the PR?

mweinelt · 2024-02-07T17:15:34Z

The pythonSupport flag is also broken, the build always enables python support unconditionally.

mweinelt · 2024-02-07T17:16:42Z

The branch is on ssh://[email protected]:cbourjau/nixpkgs.git.

SomeoneSerge · 2024-02-07T17:24:21Z

pkgs/development/libraries/onnxruntime/0001-eigen-allow-dependency-injection.patch

This could've been a smaller diff. The real change is that we add FIND_PACKAGE_ARGS everywhere, and later 1) alias eigen (abused by onnxruntime) to Eigen3::Eigen (declared by eigen), 2) set something_INCLUDE_DIRS (abused by onnxruntime) because apparently they don't even consistently use eigen as a target, 3) replace the low-level Populate (never to be used) with the higher-level MakeAvailable

The 2nd item could be done in a cleaner manner by querying stuff about the Eigen3::Eigen target but honestly not worth thinking over, because we should open an issue upstream

I worry most about someone not familiar with CMake having to rebase those patches, given the precarious maintenance situation. 🤔

Minimized the patch and added comments to navigate updaters

I wonder if we should just fetchpatch from vcpkg or conan, because (again) they are working in the same direction: https://github.com/conan-io/conan-center-index/blob/b362f2bb9f266d8f4cf9a5520a0c2977ed9f2500/recipes/onnxruntime/all/patches/1.16.0-0001-cmake-dependencies.patch#L24

SomeoneSerge

No objections to merging from my side.
The FetchContent/git-submodules mess needs to be untangled at some point, but this PR was meant as an update

SomeoneSerge · 2024-02-07T21:43:17Z

pkgs/development/libraries/onnxruntime/default.nix

RE: darwin

It's just a timeout seems like:

error: building of '/nix/store/y3h8gjk3l1myg7fv5l27v3cz7j48v5yy-onnxruntime-1.16.3.drv!out' from .drv file timed out after 3600 seconds

cbourjau · 2024-02-08T10:03:27Z

Thank you all for pushing this forward! ❤️

EDIT: Yup, it just works, no patching seems to be needed. Or are we expecting a runtime error?

@SomeoneSerge I'm afraid the patch is needed for Darwin: https://hydra.nixos.org/build/248915128/nixlog/1

SomeoneSerge · 2024-02-08T14:06:00Z

pkgs/development/libraries/onnxruntime/default.nix

Ah, I see. Thanks for spotting! We can apply it unconditionally now, in eigen's patches

ofborg bot requested review from ck3d, jonringer and puffnfresh October 1, 2023 13:00

autrimpo mentioned this pull request Oct 12, 2023

onnxruntime: add CUDA support #260745

Merged

12 tasks

cbourjau force-pushed the update-onnxruntime branch from ec11a23 to aff23f4 Compare January 14, 2024 16:01

cbourjau changed the title ~~onnxruntime: 1.15.1 -> 1.16.0~~ onnxruntime: 1.15.1 -> 1.16.3 Jan 14, 2024

cbourjau force-pushed the update-onnxruntime branch from aff23f4 to 3ceebee Compare January 14, 2024 22:40

github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jan 14, 2024

cbourjau force-pushed the update-onnxruntime branch from 3ceebee to cb43aae Compare January 14, 2024 22:42

github-actions bot removed the 6.topic: python Python is a high-level, general-purpose programming language. label Jan 14, 2024

cbourjau marked this pull request as ready for review January 15, 2024 00:43

ofborg bot added the 8.has: package (new) This PR adds a new package label Jan 15, 2024

Zahrun reviewed Jan 15, 2024

View reviewed changes

pkgs/development/libraries/onnxruntime/default.nix Outdated Show resolved Hide resolved

cbourjau force-pushed the update-onnxruntime branch from cb43aae to 89ff070 Compare January 21, 2024 00:07

ofborg bot requested a review from FRidh January 21, 2024 01:30

pinpox mentioned this pull request Jan 22, 2024

Build failure: onnxruntime #282465

Closed

mweinelt reviewed Jan 29, 2024

View reviewed changes

pkgs/development/libraries/onnxruntime/default.nix Outdated Show resolved Hide resolved

mweinelt reviewed Jan 29, 2024

View reviewed changes

pkgs/development/libraries/onnxruntime/default.nix Outdated Show resolved Hide resolved

mweinelt mentioned this pull request Jan 29, 2024

python311Packages.onnxruntime fails to build, x86_64 24.05 #284145

Closed

mweinelt linked an issue Jan 29, 2024 that may be closed by this pull request

python311Packages.onnxruntime fails to build, x86_64 24.05 #284145

Closed

Zahrun mentioned this pull request Jan 30, 2024

obs-studio-plugins.obs-backgroundremoval: 0.5.16 -> 1.1.13 #230775

Merged

12 tasks

jonringer reviewed Feb 3, 2024

View reviewed changes

pkgs/development/libraries/onnxruntime/default.nix Outdated Show resolved Hide resolved

pkgs/development/libraries/onnxruntime/default.nix Outdated Show resolved Hide resolved

kevinmehall mentioned this pull request Feb 6, 2024

onnxruntime: 1.15.1 -> 1.16.3 #285821

Closed

13 tasks

Atemu marked this pull request as draft February 7, 2024 12:20

mweinelt force-pushed the update-onnxruntime branch from 89ff070 to 9aa468b Compare February 7, 2024 16:28

mweinelt marked this pull request as ready for review February 7, 2024 16:35

ofborg bot requested a review from jonringer February 7, 2024 16:51

mweinelt force-pushed the update-onnxruntime branch from 9aa468b to 28c1d05 Compare February 7, 2024 16:57

SomeoneSerge reviewed Feb 7, 2024

View reviewed changes

onnxruntime: use system eigen

3392575

SomeoneSerge force-pushed the update-onnxruntime branch from f7c321a to 3392575 Compare February 7, 2024 17:50

SomeoneSerge approved these changes Feb 7, 2024

View reviewed changes

SomeoneSerge reviewed Feb 7, 2024

View reviewed changes

mweinelt merged commit ee2312f into NixOS:master Feb 7, 2024

cbourjau deleted the update-onnxruntime branch February 8, 2024 01:25

SomeoneSerge reviewed Feb 8, 2024

View reviewed changes

SomeoneSerge mentioned this pull request Feb 8, 2024

onnxruntime: fix aarch64-darwin #287255

Merged

13 tasks

Uh oh!

Comments

Conversation

cbourjau commented Oct 1, 2023 • edited by mweinelt Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of changes

Things done

Uh oh!

cbourjau commented Oct 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Zahrun commented Jan 13, 2024

Uh oh!

cbourjau commented Jan 15, 2024

Uh oh!

Uh oh!

Zahrun commented Jan 17, 2024

Uh oh!

Scrumplex commented Jan 20, 2024

Uh oh!

Scrumplex commented Jan 20, 2024

Uh oh!

Scrumplex commented Jan 20, 2024

Uh oh!

cbourjau commented Jan 21, 2024

Uh oh!

cbourjau commented Jan 21, 2024

Uh oh!

Scrumplex commented Jan 21, 2024

Uh oh!

pinpox commented Jan 23, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cbourjau commented Feb 7, 2024

Uh oh!

spikespaz commented Feb 7, 2024

Uh oh!

mweinelt commented Feb 7, 2024

Uh oh!

mweinelt commented Feb 7, 2024

Uh oh!

SomeoneSerge left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mweinelt commented Feb 7, 2024

Uh oh!

mweinelt commented Feb 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SomeoneSerge Feb 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mweinelt Feb 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SomeoneSerge Feb 7, 2024

Choose a reason for hiding this comment

Uh oh!

SomeoneSerge Feb 7, 2024

Choose a reason for hiding this comment

Uh oh!

SomeoneSerge left a comment

Choose a reason for hiding this comment

Uh oh!

SomeoneSerge Feb 7, 2024

Choose a reason for hiding this comment

Uh oh!

cbourjau commented Feb 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SomeoneSerge Feb 8, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

cbourjau commented Oct 1, 2023 •

edited by mweinelt

Loading

cbourjau commented Oct 2, 2023 •

edited

Loading

SomeoneSerge left a comment •

edited

Loading

mweinelt commented Feb 7, 2024 •

edited

Loading

SomeoneSerge Feb 7, 2024 •

edited

Loading

mweinelt Feb 7, 2024 •

edited

Loading

cbourjau commented Feb 8, 2024 •

edited

Loading