direwolf: make various buildInputs optional#258056
Merged
FRidh merged 3 commits intoNixOS:masterfrom Sep 29, 2023
Merged
Conversation
sarcasticadmin
force-pushed
the
rh/1695937430dirwolf
branch
from
c5627d8 to
42dd7f0
Compare
sarcasticadmin
force-pushed
the
rh/1695937430dirwolf
branch
from
42dd7f0 to
2445620
Compare
ofborg
bot
added
11.by: package-maintainer
direwolf includes a set of extra scripts which showcase various capabilities of the pkg. However, they depend on languages that are not critical to building direwolf itself.
sarcasticadmin
force-pushed
the
rh/1695937430dirwolf
branch
from
2445620 to
d514277
Compare
MatthewCroughan
approved these changes
Sep 29, 2023
delroth
added
the
12.approvals: 1
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
direwolf only depends on a
cmake, alsa-lib, udev(https://github.com/wb2osz/direwolf/tree/1.6#linux---using-git-clone-recommended) and should have each of its additional dependencies marked as options (gpsd,hamlib).Adding
extraScriptsoption to exclude various scripts that are more of examples of direwolf capabilities vs required for using the tool.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)