Skip to content

[Backport release-23.05] signal-desktop-beta: 6.30.0-beta.2 -> 6.31.0-beta.1, signal-desktop-beta: 6.31.0-beta.1 -> 6.32.0-beta.1#257169

Merged
Mic92 merged 2 commits intoNixOS:release-23.05from
SebTM:signal_update_923
Sep 25, 2023
Merged

[Backport release-23.05] signal-desktop-beta: 6.30.0-beta.2 -> 6.31.0-beta.1, signal-desktop-beta: 6.31.0-beta.1 -> 6.32.0-beta.1#257169
Mic92 merged 2 commits intoNixOS:release-23.05from
SebTM:signal_update_923

Conversation

@SebTM
Copy link
Contributor

@SebTM SebTM commented Sep 25, 2023 •
edited
Loading

Description of changes

Backport beta-release commits as mentioned #254798 (comment)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Sep 25, 2023
@Mic92 Mic92 merged commit 0a78df4 into NixOS:release-23.05 Sep 25, 2023
@delroth delroth mentioned this pull request Sep 26, 2023
Closed
90 tasks
@equirosa
Copy link
Contributor

equirosa commented Sep 27, 2023

Thanks for backporting! Quick question: is it ok to also backport 6.31.0 for signal-desktop? Ideally we'd keep them in sync, but if 6.31.0 has the same vulnerability that 6.31.0-beta1 did then it makes sense to avoid it

@SebTM
Copy link
Contributor Author

SebTM commented Sep 27, 2023 •
edited
Loading

I mean yes you are right but it just changes the point where we have a big jump in versions about a few days - when the fixed version is released we will bump on stable again I guess?

Edit: Should I revert the update for the non-beta package?

@equirosa
Copy link
Contributor

equirosa commented Sep 27, 2023

Hmm that's fair 🤔 given that we'd probably have to do it manually anyway, I don't think there's a need to rush it. We could wait until the next one.

@SebTM SebTM deleted the signal_update_923 branch September 28, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SebTM @equirosa @Mic92 @kilianar