[Backport release-23.05] slack: 4.29.149 -> 4.34.120 (linux), 4.29.149 -> 4.34.119 (darwin)#257149
[Backport release-23.05] slack: 4.29.149 -> 4.34.120 (linux), 4.29.149 -> 4.34.119 (darwin)#257149delroth merged 1 commit intoNixOS:release-23.05from SebTM:slack_923
Conversation
|
Can you rebase this against release-23.05 please? I don't think this technically meets the backporting guidelines but 🤷♀️ |
|
Ah, you're correct, this is the wrong branch (luckily the automated checks caught it :) )
It absolutely does. What in the guidelines do you think this goes against? (for reference: https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#changes-acceptable-for-releases) |
|
@delroth Each commit should be individually cherry picked with a reference to the original commit ( |
Ah, I see what you mean - thanks for bringing this up. I don't think the guidelines explicitly require this per se, but it's indeed heavily recommended when the cherry picks do apply cleanly. In a case like this I don't think I have a strong preference between cherry-picking the missing series of bumps vs. just squashing it into one big commit, and I don't think this has ever come up as "something one shouldn't do" in any previous backport PR I've dealt with. I'll bring that up on Matrix to see if others have opinions. |
|
(Actually, I can fix that myself, heh.) |
This change was backported from this commit: d83fafb
|
The opinions I got on Matrix didn't suggest that the way this backport was done should be blocking anything, so merging this to try and move the vuln remediation forward. |
Description of changes
Backport #257135 // cc @delroth
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)