Skip to content

[Backport release-23.05] slack: 4.29.149 -> 4.34.120 (linux), 4.29.149 -> 4.34.119 (darwin)#257149

Merged
delroth merged 1 commit intoNixOS:release-23.05from
SebTM:slack_923
Sep 26, 2023
Merged

[Backport release-23.05] slack: 4.29.149 -> 4.34.120 (linux), 4.29.149 -> 4.34.119 (darwin)#257149
delroth merged 1 commit intoNixOS:release-23.05from
SebTM:slack_923

Conversation

@SebTM
Copy link
Contributor

@SebTM SebTM commented Sep 24, 2023

Description of changes

Backport #257135 // cc @delroth

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@SebTM SebTM changed the title slack: 4.29.149 -> 4.34.120 (linux), 4.29.149 -> 4.34.119 (darwin) [Backport release-23.05] slack: 4.29.149 -> 4.34.120 (linux), 4.29.149 -> 4.34.119 (darwin) Sep 24, 2023
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Sep 24, 2023
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Sep 24, 2023
@amaxine
Copy link
Contributor

amaxine commented Sep 24, 2023

Can you rebase this against release-23.05 please? I don't think this technically meets the backporting guidelines but 🤷‍♀️

@delroth
Copy link
Contributor

delroth commented Sep 24, 2023

Ah, you're correct, this is the wrong branch (luckily the automated checks caught it :) )

I don't think this technically meets the backporting guidelines

It absolutely does. What in the guidelines do you think this goes against? (for reference: https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#changes-acceptable-for-releases)

@amaxine
Copy link
Contributor

amaxine commented Sep 24, 2023

@delroth Each commit should be individually cherry picked with a reference to the original commit (-x), I don't think there's generally any exceptions to doing that when backporting changes as in this PR, rather than e.g. pulling in a singular patch to address security issues.

@delroth
Copy link
Contributor

delroth commented Sep 24, 2023

@delroth Each commit should be individually cherry picked with a reference to the original commit (-x), I don't think there's generally any exceptions to doing that when backporting changes as in this PR, rather than e.g. pulling in a singular patch to address security issues.

Ah, I see what you mean - thanks for bringing this up. I don't think the guidelines explicitly require this per se, but it's indeed heavily recommended when the cherry picks do apply cleanly. In a case like this I don't think I have a strong preference between cherry-picking the missing series of bumps vs. just squashing it into one big commit, and I don't think this has ever come up as "something one shouldn't do" in any previous backport PR I've dealt with.

I'll bring that up on Matrix to see if others have opinions.

@delroth delroth changed the base branch from nixos-23.05 to release-23.05 September 24, 2023 23:08
@delroth
Copy link
Contributor

delroth commented Sep 24, 2023

(Actually, I can fix that myself, heh.)

@delroth delroth added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Sep 24, 2023
@ofborg ofborg bot requested a review from mmahut September 24, 2023 23:26
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Sep 24, 2023
@delroth delroth removed the 12.approvals: 1 This PR was reviewed and approved by one person. label Sep 25, 2023
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Sep 25, 2023
@delroth
Copy link
Contributor

delroth commented Sep 26, 2023

The opinions I got on Matrix didn't suggest that the way this backport was done should be blocking anything, so merging this to try and move the vuln remediation forward.

@delroth delroth merged commit 6e534f0 into NixOS:release-23.05 Sep 26, 2023
@SebTM SebTM deleted the slack_923 branch November 16, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants