Skip to content

pkgsStatic.cairo: fix build#256519

Closed
alyssais wants to merge 1 commit intoNixOS:masterfrom
alyssais:pkgsStatic.cairo
Closed

pkgsStatic.cairo: fix build#256519
alyssais wants to merge 1 commit intoNixOS:masterfrom
alyssais:pkgsStatic.cairo

Conversation

@alyssais
Copy link
Member

Description of changes

mesaPlatforms isn't precise enough to exclude static builds, so switch to availableOn.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@alyssais alyssais added the 6.topic: static Static builds (e.g. pkgsStatic) label Sep 21, 2023
mesaPlatforms isn't precise enough to exclude static builds, so switch
to availableOn.
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Sep 22, 2023
@alyssais alyssais mentioned this pull request Sep 25, 2023
12 tasks
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice use of meta.availableOn!

Built on:

  • x86_64-linux

@alyssais
Copy link
Member Author

This is going to be fixed by #257301 anyway, because Cairo just completely removed the GL backend.

@pbsds pbsds added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 27, 2023
@alyssais alyssais closed this Dec 3, 2023
@alyssais alyssais deleted the pkgsStatic.cairo branch December 3, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: static Static builds (e.g. pkgsStatic) 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants