Closed
Conversation
Contributor
|
Result of 1 package built:
|
Member
Author
|
On second thought this seems very niche, so a flake outside of nixpkgs might make more sense? WDYT? |
Contributor
|
Personally I want to see all of the Gnome Circle apps, including this one in nixpkgs. |
Member
Author
|
OK, I'm not against it, feel free to add yourself as maintainer because I might drop it if it becomes cumbersome :) |
Contributor
|
You can add me to the list in the nix file if you want. |
bdd24c0 to
c165a10
Compare
Member
Author
updated! |
Aleksanaa
reviewed
Mar 12, 2024
| homepage = "https://github.com/rafaelmardojai/share-preview"; | ||
| license = licenses.gpl3Only; | ||
| maintainers = with maintainers; [ gaykitty ]; | ||
| platforms = platforms.all; |
Member
There was a problem hiding this comment.
mainProgram is always needed now, despite being the same with pname.
Aleksanaa
reviewed
Apr 5, 2024
| pkg-config | ||
| meson | ||
| glib | ||
| gtk4 |
Member
There was a problem hiding this comment.
Suggested change
| gtk4 | |
| wrapGAppsHook4 |
| gdk-pixbuf | ||
| gtk4 | ||
| libadwaita | ||
| wrapGAppsHook |
Member
There was a problem hiding this comment.
Suggested change
| wrapGAppsHook |
| hash = "sha256-CsnWQxE2r+uWwuEzHpY/lpWS5i8OXvhRKvy2HzqnQ5U="; | ||
| }; | ||
|
|
||
| buildPhase = '' |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)