Skip to content

signal-desktop: 6.30.2 -> 6.31.0, signal-desktop-beta: 6.31.0-beta.1 -> 6.32.0-beta.1#256435

Merged
delroth merged 1 commit intoNixOS:masterfrom
equirosa:signal-desktop-6.31.0-and-6.32.0-beta.1
Sep 21, 2023
Merged

signal-desktop: 6.30.2 -> 6.31.0, signal-desktop-beta: 6.31.0-beta.1 -> 6.32.0-beta.1#256435
delroth merged 1 commit intoNixOS:masterfrom
equirosa:signal-desktop-6.31.0-and-6.32.0-beta.1

Conversation

@equirosa
Copy link
Contributor

@equirosa equirosa commented Sep 21, 2023 •
edited
Loading

Description of changes

Updates

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@equirosa equirosa added backport release-23.05 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. labels Sep 21, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Sep 21, 2023
kilianar
kilianar approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@kilianar kilianar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes do look good to me. A quick test of the binaries indicates that everything appears to be functioning correctly.

Result of nixpkgs-review pr 256435 run on x86_64-linux 1

2 packages built:
  • signal-desktop
  • signal-desktop-beta

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Sep 21, 2023
@cmovcc cmovcc mentioned this pull request Sep 21, 2023
Closed
90 tasks
@delroth delroth added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Sep 21, 2023
@delroth
Copy link
Contributor

delroth commented Sep 21, 2023

FWIW the release notes don't explicitly say so, but I've confirmed that the new -beta uses electron 25.8.1 which is patched.

@delroth delroth merged commit d9c6fcb into NixOS:master Sep 21, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 21, 2023

Backport failed for release-23.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-23.05
git worktree add -d .worktree/backport-256435-to-release-23.05 origin/release-23.05
cd .worktree/backport-256435-to-release-23.05
git checkout -b backport-256435-to-release-23.05
ancref=$(git merge-base 28c306a5ce8910b9ed688d672d7224131ea34f94 4f6b3ac83018238ea3940c1a1f208669cf1331a3)
git cherry-pick -x $ancref..4f6b3ac83018238ea3940c1a1f208669cf1331a3

@delroth
Copy link
Contributor

delroth commented Sep 21, 2023

Ugh, can you do the cherry-pick manually and cc me on the PR? Thanks!

@equirosa
Copy link
Contributor Author

equirosa commented Sep 22, 2023 via email

@equirosa
Copy link
Contributor Author

equirosa commented Sep 23, 2023

Upon closer inspection, it might be rather difficult to cherry-pick this commit directly, since the versions in release-23.05 weren't updated from commits in master. I'll just make a PR for that branch with the same versions in this one.

@equirosa equirosa deleted the signal-desktop-6.31.0-and-6.32.0-beta.1 branch September 27, 2023 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@delroth delroth delroth approved these changes

@kilianar kilianar kilianar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@equirosa @delroth @kilianar