lib: add cmakeOption and cmakeBool#256418
Merged
AndersonTorres merged 3 commits intoNixOS:masterfrom Sep 27, 2023
atorres1985-contrib:cmake-option
Merged
lib: add cmakeOption and cmakeBool#256418AndersonTorres merged 3 commits intoNixOS:masterfrom atorres1985-contrib:cmake-option
AndersonTorres merged 3 commits intoNixOS:masterfrom
atorres1985-contrib:cmake-option
Conversation
12 tasks
ofborg
bot
added
10.rebuild-darwin: 0
Member
Author
|
These vars can hold data types: It looks too gui-driven, and also too dependent on the upstream - what if this variables are truly strings that happen to act like booleans? For now I will treat the default as STRING. |
ofborg
bot
added
11.by: package-maintainer
Member
lilyinstarlight
left a comment
lilyinstarlight
left a comment
There was a problem hiding this comment.
The G'MIC derivation changes themselves look fine to me (aside from the second commit title erroneously using gmic: instead of gmic-qt: which is a minor typo), but I'll make no comment on the overall change right now
Ofborg requested my review for gmic so I figured I'd give it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)