Skip to content

gitter: remove (unmaintained upstream, probably useless now)#255784

Merged
fabianhjr merged 1 commit intoNixOS:masterfrom
delroth:gitter-rm
Sep 18, 2023
Merged

gitter: remove (unmaintained upstream, probably useless now)#255784
fabianhjr merged 1 commit intoNixOS:masterfrom
delroth:gitter-rm

Conversation

@delroth
Copy link
Contributor

@delroth delroth commented Sep 18, 2023

Description of changes

Remove the gitter package: no more upstream release in a while, upstream tells people to just use a Matrix client these days. My understanding is that this is the client for the Gitter backend pre-Matrix-migration, which doesn't exist anymore, so nobody should have a use case for it anymore.

cc @colonelpanic8

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@delroth
Copy link
Contributor Author

delroth commented Sep 18, 2023

ref #254798

@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Sep 18, 2023
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Sep 18, 2023
@fabianhjr fabianhjr added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Sep 18, 2023
@fabianhjr fabianhjr merged commit 91b20bb into NixOS:master Sep 18, 2023
@delroth delroth deleted the gitter-rm branch October 2, 2023 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants