Skip to content

[23.05] qt5.qtimageformats: unvendor libwebp#255432

Merged
vcunat merged 1 commit intoNixOS:release-23.05from
vcunat:p/qt5.qtimageformats-libwebp
Sep 16, 2023
Merged

[23.05] qt5.qtimageformats: unvendor libwebp#255432
vcunat merged 1 commit intoNixOS:release-23.05from
vcunat:p/qt5.qtimageformats-libwebp

Conversation

@vcunat
Copy link
Member

@vcunat vcunat commented Sep 16, 2023

It was most likely affected by CVE-2023-4863.

This is a minimalist version of 72e3962 (from nixpkgs master), as I don't think we need to add extra functionality/formats on stable.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

It was most likely affected by CVE-2023-4863.

This is a minimalist version of 72e3962 (from nixpkgs master),
as I don't think we need to add extra functionality/formats on stable.
@vcunat vcunat added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Sep 16, 2023
@vcunat vcunat requested a review from ttuegel as a code owner September 16, 2023 07:12
@github-actions github-actions bot added the 6.topic: qt/kde Object-oriented framework for GUI creation label Sep 16, 2023
@vcunat
Copy link
Member Author

vcunat commented Sep 16, 2023

@ofborg build qt5.qtimageformats
(for other platforms)

@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Sep 16, 2023
@vcunat
Copy link
Member Author

vcunat commented Sep 16, 2023

review built 58 packages, all successfully.

@vcunat vcunat merged commit b2729e3 into NixOS:release-23.05 Sep 16, 2023
@vcunat vcunat deleted the p/qt5.qtimageformats-libwebp branch September 16, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 6.topic: qt/kde Object-oriented framework for GUI creation 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant