Skip to content

python3.pkgs.primer3: enable tests#255260

Merged
doronbehar merged 1 commit intoNixOS:masterfrom
doronbehar:pkg/primer
Sep 30, 2023
Merged

python3.pkgs.primer3: enable tests#255260
doronbehar merged 1 commit intoNixOS:masterfrom
doronbehar:pkg/primer

Conversation

@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Sep 15, 2023

Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Sep 15, 2023
@ppom0
Copy link
Contributor

ppom0 commented Sep 15, 2023

LGTM

@doronbehar
Copy link
Contributor Author

doronbehar commented Sep 15, 2023

Let's give a bit of time for upstream to respond on the issue I just opened there (libnano/primer3-py#120).

@doronbehar doronbehar mentioned this pull request Sep 15, 2023
Open
13 tasks
@ofborg ofborg bot requested a review from fabaff September 15, 2023 09:49
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Sep 15, 2023
@doronbehar
Copy link
Contributor Author

doronbehar commented Sep 16, 2023

Thanks to upstream's help at libnano/primer3-py#120, I think this should be ready. I'll wait for @fabaff 's approval for a few days, and if they won't reply I'll merge this.

@doronbehar doronbehar changed the title python3.pkgs.primer3: better explain why tests are disabled python3.pkgs.primer3: enable tests Sep 16, 2023
@doronbehar doronbehar merged commit 591a09e into NixOS:master Sep 30, 2023
@doronbehar doronbehar deleted the pkg/primer branch September 30, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabaff fabaff Awaiting requested review from fabaff

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@doronbehar @ppom0