Skip to content

python3.pkgs.xdot: 1.2 -> 1.3#255254

Merged
doronbehar merged 1 commit intoNixOS:masterfrom
doronbehar:pkg/python-xdot
Oct 6, 2023
Merged

python3.pkgs.xdot: 1.2 -> 1.3#255254
doronbehar merged 1 commit intoNixOS:masterfrom
doronbehar:pkg/python-xdot

Conversation

@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Sep 15, 2023

Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Sep 15, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Sep 15, 2023
@doronbehar doronbehar mentioned this pull request Sep 15, 2023
Open
13 tasks
@doronbehar doronbehar requested a review from kilianar October 4, 2023 12:57
@doronbehar
Copy link
Contributor Author

doronbehar commented Oct 6, 2023

I prevented another double wrapping. Tested it again, and it seems functional. Will merge when CI is green.

kilianar
kilianar reviewed Oct 6, 2023
View reviewed changes
kilianar
kilianar reviewed Oct 6, 2023
View reviewed changes
@kilianar
Copy link
Contributor

kilianar commented Oct 6, 2023

The changes look good to me, and I can confirm that the application runs fine on a simple example graph.

@doronbehar
python3.pkgs.xdot: 1.2 -> 1.3
2f244e3 
Numerous other fixes / improvements:
- Format expression with 1 line per argument and input
- Use fetchFromGitHub to fetch the `test.py` file not distributed with
  the pypi source.
- Enable tests.
- Prevent double wrapping by setting makeWrapperArgs instead of using
  wrapProgram.
- Run check hooks.
@doronbehar
Copy link
Contributor Author

doronbehar commented Oct 6, 2023

Thanks for the review :).

@doronbehar doronbehar merged commit da31701 into NixOS:master Oct 6, 2023
@doronbehar doronbehar deleted the pkg/python-xdot branch October 6, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kilianar kilianar kilianar left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@doronbehar @kilianar