signal-desktop: 6.30.1 -> 6.30.2#255129
Merged
delroth merged 1 commit intoNixOS:masterfrom Sep 14, 2023
cmovcc:signal-desktop-update
Merged
signal-desktop: 6.30.1 -> 6.30.2#255129delroth merged 1 commit intoNixOS:masterfrom cmovcc:signal-desktop-update
delroth merged 1 commit intoNixOS:masterfrom
cmovcc:signal-desktop-update
Conversation
NixOSInfra
added
the
12.first-time contribution
Contributor
Author
|
I guess it is worth referencing the WebP CVE (CVE-2023-4863) tracking: #254798. |
ofborg
bot
added
10.rebuild-darwin: 0
Contributor
|
@ofborg build signal-desktop |
delroth
approved these changes
Sep 14, 2023
Contributor
delroth
left a comment
delroth
left a comment
There was a problem hiding this comment.
Code change LGTM, I'll merge if ofborg is happy.
delroth
added
1.severity: security
90 tasks
Contributor
|
Backport failed for Please cherry-pick the changes locally. git fetch origin release-23.05
git worktree add -d .worktree/backport-255129-to-release-23.05 origin/release-23.05
cd .worktree/backport-255129-to-release-23.05
git checkout -b backport-255129-to-release-23.05
ancref=$(git merge-base c8430909172201d1e24688aeef57d5de624e196d e24efaf742a1db68433706396ae6b8ecf642a3a9)
git cherry-pick -x $ancref..e24efaf742a1db68433706396ae6b8ecf642a3a9 |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
signal-desktop: 6.30.1 -> 6.30.2
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)This version of signal-desktop contains "the latest version of the Electron v25 stable branch that was just published with a fix for [the WebP bug] in Chrome", see signalapp/Signal-Desktop#6603 (comment). I did not test the signal-desktop-beta latest version yet.