Skip to content

catppucin-catwalk: use system libwebp#254911

Merged
delroth merged 1 commit intoNixOS:masterfrom
yu-re-ka:webp-catppucin-catwalk
Sep 14, 2023
Merged

catppucin-catwalk: use system libwebp#254911
delroth merged 1 commit intoNixOS:masterfrom
yu-re-ka:webp-catppucin-catwalk

Conversation

@yu-re-ka
Copy link
Contributor

@yu-re-ka yu-re-ka commented Sep 13, 2023

Description of changes

#254798

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from ryanccn September 13, 2023 09:23
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Sep 13, 2023
@ryanccn ryanccn added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Sep 14, 2023
@delroth delroth merged commit 019809f into NixOS:master Sep 14, 2023
@delroth delroth added 1.severity: security Issues which raise a security issue, or PRs that fix one backport release-23.05 labels Sep 14, 2023
@github-actions
Copy link
Contributor

Backport failed for release-23.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-23.05
git worktree add -d .worktree/backport-254911-to-release-23.05 origin/release-23.05
cd .worktree/backport-254911-to-release-23.05
git checkout -b backport-254911-to-release-23.05
ancref=$(git merge-base 1697b7d480449b01111e352021f46e5879e47643 09fcb6597d5d3b6a24b080ca94d5b84f8ce2196e)
git cherry-pick -x $ancref..09fcb6597d5d3b6a24b080ca94d5b84f8ce2196e

1 similar comment
@github-actions
Copy link
Contributor

Backport failed for release-23.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-23.05
git worktree add -d .worktree/backport-254911-to-release-23.05 origin/release-23.05
cd .worktree/backport-254911-to-release-23.05
git checkout -b backport-254911-to-release-23.05
ancref=$(git merge-base 1697b7d480449b01111e352021f46e5879e47643 09fcb6597d5d3b6a24b080ca94d5b84f8ce2196e)
git cherry-pick -x $ancref..09fcb6597d5d3b6a24b080ca94d5b84f8ce2196e

@delroth
Copy link
Contributor

delroth commented Sep 14, 2023

Because that package didn't exist in 23.05, ok :-)

@yu-re-ka yu-re-ka deleted the webp-catppucin-catwalk branch September 14, 2023 15:58
nekowinston added a commit to catppuccin/toolbox that referenced this pull request Nov 4, 2023
nekowinston added a commit to catppuccin/toolbox that referenced this pull request Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants