http-parser: fix copying outputs for static build#254516
Merged
Ericson2314 merged 2 commits intoNixOS:stagingfrom Nov 30, 2023
Merged
http-parser: fix copying outputs for static build#254516Ericson2314 merged 2 commits intoNixOS:stagingfrom
Ericson2314 merged 2 commits intoNixOS:stagingfrom
Conversation
FliegendeWurst
requested changes
Nov 3, 2023
Member
FliegendeWurst
left a comment
There was a problem hiding this comment.
This PR should target staging since it rebuilds a lot of packages.
Patch itself LGTM.
Contributor
Author
changed base, thx for the info 👍 @FliegendeWurst |
FliegendeWurst
approved these changes
Nov 3, 2023
Since 4056c43 a Make not Gyp build system has been in use.
Co-Authored-By: John Ericson <[email protected]>
7607111 to
33f464b
Compare
Ericson2314
approved these changes
Nov 30, 2023
Member
Ericson2314
left a comment
There was a problem hiding this comment.
I coincidentally did this locally --- I combined with my version to fix conflicts but still give you credit
Member
|
eval lib tests failure is unrelated. |
Contributor
|
Successfully created backport PR for |
1 task
Contributor
|
Git push to origin failed for staging-23.05 with exitcode 1 |
Contributor
|
Successfully created backport PR for |
1 task
Contributor
|
Git push to origin failed for staging-23.11 with exitcode 1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixes derivation for http-parser in a static env to
installthe static archive to$out/lib, based on the following issue and non-upstreamed nix solution.Currently,
pkgsStatic.http-parseronly results in a shared library in$out/lib:After this change, we only have the static archive file:
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)