Skip to content

Comments

Wmaker update#254316

Merged
AndersonTorres merged 3 commits intoNixOS:masterfrom
atorres1985-contrib:wmaker
Sep 10, 2023
Merged

Wmaker update#254316
AndersonTorres merged 3 commits intoNixOS:masterfrom
atorres1985-contrib:wmaker

Conversation

@AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Sep 10, 2023

Description of changes

Now with by-name support!

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Sep 10, 2023
@AndersonTorres AndersonTorres marked this pull request as ready for review September 10, 2023 11:07
@AndersonTorres AndersonTorres merged commit 41b498c into NixOS:master Sep 10, 2023
@AndersonTorres AndersonTorres deleted the wmaker branch September 10, 2023 12:15

windowmaker = callPackage ../applications/window-managers/windowmaker { };
dockapps = callPackage ../applications/window-managers/windowmaker/dockapps { };
dockapps = callPackage ../by-name/wi/windowmaker/dockapps { };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this is something I didn't expect 😅

I guess it's not a problem, it will fall under a future refactoring of package sets

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windowmaker dockapps live in a limbo.
In theory they can run in any window manager that provides dockapp support.
However, there are only Windowmaker and Afterstep that provides this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants