Skip to content

python310Packages.buildPythonPackage: introduce pyproject option#254136

Merged
FRidh merged 5 commits intoNixOS:masterfrom
figsoda:python
Sep 14, 2023
Merged

python310Packages.buildPythonPackage: introduce pyproject option#254136
FRidh merged 5 commits intoNixOS:masterfrom
figsoda:python

Conversation

@figsoda
Copy link
Member

@figsoda figsoda commented Sep 9, 2023 •
edited
Loading

Description of changes

#253154

adds the pyproject option that conflicts with format, where pyproject = true is equivalent to format = "pyproject", and pyproject = false is equivalent to format = "other", and 3 more commits to demonstrate the conversion of format = "pyproject" | "setuptools" | "other" to the pyproject option

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@figsoda figsoda requested a review from FRidh as a code owner September 9, 2023 00:48
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Sep 9, 2023
@figsoda figsoda mentioned this pull request Sep 9, 2023
Open
2 tasks
@ofborg ofborg bot requested review from Mic92 and zowoq September 9, 2023 01:08
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Sep 9, 2023
@pbsds
Copy link
Member

pbsds commented Sep 9, 2023

The documentation here needs some love

@figsoda figsoda requested a review from mweinelt as a code owner September 9, 2023 14:53
@github-actions github-actions bot added the 8.has: documentation This PR adds or changes documentation label Sep 9, 2023
@figsoda
Copy link
Member Author

figsoda commented Sep 9, 2023

The documentation here needs some love

replaced all the formats in the documentation with pyproject

FRidh
FRidh reviewed Sep 9, 2023
View reviewed changes
doc/languages-frameworks/python.section.md Outdated
Copy link
Member

@FRidh FRidh Sep 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How? setuptools is not supposed to be available by default.

Copy link
Member Author

@figsoda figsoda Sep 9, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by that I mean pypaBuildHook will try to use setuptools even if pyproject.toml doesn't exist, but it still needs to be added to nativeBuildInputs

@figsoda
Copy link
Member Author

figsoda commented Sep 12, 2023

fixed merge conflicts

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Sep 13, 2023
@figsoda figsoda mentioned this pull request Sep 13, 2023
Merged
@FRidh FRidh merged commit 53dd1a6 into NixOS:master Sep 14, 2023
@figsoda figsoda deleted the python branch September 14, 2023 17:30
This was referenced Nov 20, 2023
Merged
Closed
Merged
@WolfangAukang WolfangAukang mentioned this pull request Dec 8, 2023
Merged
13 tasks
This was referenced Dec 27, 2023
Closed
Closed
@thiagokokada thiagokokada mentioned this pull request Feb 15, 2024
Merged
13 tasks
@neobrain neobrain mentioned this pull request Jul 15, 2025
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mic92 Mic92 Mic92 approved these changes

@zowoq zowoq Awaiting requested review from zowoq

@mweinelt mweinelt Awaiting requested review from mweinelt

+1 more reviewer

@FRidh FRidh FRidh left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@figsoda @pbsds @Mic92 @FRidh @delroth