Skip to content

ffmpeg: re-enable video4linux2 support#253915

Merged
rnhmjoj merged 1 commit intoNixOS:stagingfrom
rnhmjoj:pr-ffmpeg
Sep 11, 2023
Merged

ffmpeg: re-enable video4linux2 support#253915
rnhmjoj merged 1 commit intoNixOS:stagingfrom
rnhmjoj:pr-ffmpeg

Conversation

@rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Sep 7, 2023

Description of changes

This is useful in some application like mpv to view the webcam stream. It was enabled before ffmpeg and ffmpeg-full got merged in #211834.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Sep 7, 2023
@rnhmjoj rnhmjoj changed the base branch from master to staging September 8, 2023 00:05
Copy link
Contributor

@Majiir Majiir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ result-bin/bin/ffmpeg -formats
...
 DE video4linux2,v4l2 Video4Linux2 output device

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Sep 8, 2023
This is useful in some application like mpv to view the webcam stream.
It was enabled before ffmpeg and ffmpeg-full got merged in NixOS#211834.
@ofborg ofborg bot requested a review from Atemu September 9, 2023 00:08
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Sep 9, 2023
@delroth delroth removed the 12.approvals: 1 This PR was reviewed and approved by one person. label Sep 9, 2023
@rnhmjoj rnhmjoj merged commit a91401f into NixOS:staging Sep 11, 2023
@github-actions
Copy link
Contributor

Successfully created backport PR for staging-23.05:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants