1.0.0-beta.4.12.34 needs a newer GTK version than we have in nixpkgs.

Dependency gtk4 found: NO found 4.10.4 but need: '>=4.13'

GTK 4.13.0 is also still unstable.

https://www.gtk.org/
https://gitlab.gnome.org/GNOME/gtk/-/tags

@nyabinary we could update to the latest zrythm version compatible with the dependencies in nixpkgs. would that be helpful?

@bobby285271 @jtojnar updating gtk4 to latest stable (4.12.1) is a bigger project, right? is there a plan or issue to follow?

A little bit useful but I need the latest since that is preferable, also it uses a GTK 4.13 commit but only because it includes fixes for MacOS

Then this update will take some time.

updating gtk4 to latest stable

It is in GNOME 45 PR 822896a 1c34cf7. I don't have a reason to block this from bumping separately for now so probably we can try (I changed my day $job recently and have much fewer time to work on Nixpkgs things so there is no guarantee on this).

@bobby285271 it's probably not worth the risk to break a lot of packages. makes sense to update gnome at once

Be careful not to work too much!

I updated it to the previous release (1.0.0-beta.4.12.5). That's some months newer than what we have.

It does build, but when i start it, i get a lot of errors and a backtrace. I don't have Jack installed and also still run NixOS 22.11.4588.93fddcf640c.
I also have never used it, so i don't know what would be expected experience.

I also get a backtrace with pulseaudio backend and hit record.

zrythm-Message: 17:33:46.479: (segv_handler:146): Error: Segmentation fault - Backtrace:
../src/utils/backtrace.c (_backtrace_get:325)
../src/zrythm_app.c (segv_handler:139)
??? unknown
../src/gui/widgets/cpu.c (refresh_dsp_load:137)
??? g_timeout_dispatch
??? g_main_context_dispatch
??? g_main_context_iterate.constprop.0
??? g_main_context_iteration
??? g_application_run
../src/main.c (main:22)
??? __libc_start_call_main
??? __libc_start_main_alias_2
??? _start
??? unknown

Not sure if that's all my system or if this version is broken.

@nyabinary can you test this update?

How would I test it? Bit of a newbie.

This command builds the packages affected by this pull request and opens a shell that has them available. Then you can run and test them. You have to run it inside a local checkout of nixpkgs.

nix-shell -p nixpkgs-review --run "nixpkgs-review pr 253765"

Optionally, you can setup a github token to post the build result as a comment to the pull request using --post-result.

https://github.com/Mic92/nixpkgs-review#github-api-token

Result of nixpkgs-review pr 253765 run on x86_64-linux 1

@magnetophon have you tested it and verified that you don't have the crashes i experienced?

@davidak The segment fault issue is solved in the new version of Zrythm, 4.13, so should update this PR to 4.13

@nyabinary that still needs an unstable version of GTK we don't have in nixpkgs yet.

4.12 and 4.11 all crash when "save and close". i don't want to update the package to a broken state. the packaged version works. so we have to wait here

until then, you can use the flatpak as a workaround: https://flathub.org/apps/org.zrythm.Zrythm

@davidak The flatpak isnt officially supported

@nyabinary it's verified by the developers. and flatpak is supported on nixos. so it should work

Any updates on this btw?

@nyabinary No. Need to wait until the likely stable release of GTK 4.14 and then addition to Nixpkgs.

Any updates on this?

GTK 4.13 still isn't in nixpkgs, see #258634 (comment).

I'm currently using this to build zrythm 1.0.0-beta.6.0.26 with GTK 4.13.4:

{ lib, pkgs, ... }:

let
  gtk4 = pkgs.gtk4.overrideAttrs (oldAttrs: rec {
    version = "4.13.4";
  
    src = pkgs.fetchurl {
      url = "mirror://gnome/sources/gtk/${lib.versions.majorMinor version}/gtk-${version}.tar.xz";
      sha256 = "sxx1EQI6LOClFEs7a3IiH+tWPiO+Fk7N3Uh8qFm5xA8=";
    };
  
    patches = [];
  
    buildInputs = oldAttrs.buildInputs ++ [ pkgs.libdrm ];
  });
in

(pkgs.zrythm.override { inherit gtk4; }).overrideAttrs (oldAttrs: rec {
  version = "1.0.0-beta.6.0.26";

  src = pkgs.fetchFromGitLab {
    domain = "gitlab.zrythm.org";
    owner = "zrythm";
    repo = "zrythm";
    rev = "v${version}";
    hash = "sha256-9bmnrBwu91yUXIwfe5q8c/H9YUpyvJnBR+5OQPSlB3s=";
  };

  buildInputs = oldAttrs.buildInputs ++ [ pkgs.soxr pkgs.yyjson ];
})

I have updated zrythm on my own branch: PowerUser64@2aeeecc. This brings zrythm to its current version (1.0.0-beta.5.1.1). I used overrideAttrs to bring gtk to the required release, and updated carla to the latest commit.

Should I submit a PR with these changes? I don't know whether using overrideAttrs inside buildInputs is allowed in nixpkgs.

I have updated zrythm on my own branch: PowerUser64@2aeeecc. This brings zrythm to its current version (1.0.0-beta.5.1.1). I used overrideAttrs to bring gtk to the required release, and updated carla to the latest commit.

Should I submit a PR with these changes? I don't know whether using overrideAttrs inside buildInputs is allowed in nixpkgs.

overrideAttrs should be allowed.

Made a PR to update to v1.0.0-beta.6.4.1 using overrideAttrs to fill gaps in package versions where needed #290598
feel free to drop a thumbs up on it to help visibility

Superseded by #306959 (Merged)