Skip to content

llvmPackages.lldb: use substituteAll#253533

Merged
Artturin merged 4 commits intoNixOS:stagingfrom
Artturin:llvmusesuball
Sep 6, 2023
Merged

llvmPackages.lldb: use substituteAll#253533
Artturin merged 4 commits intoNixOS:stagingfrom
Artturin:llvmusesuball

Conversation

@Artturin
Copy link
Member

@Artturin Artturin commented Sep 5, 2023

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@Artturin Artturin mentioned this pull request Sep 5, 2023
12 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Sep 5, 2023
@Artturin Artturin force-pushed the llvmusesuball branch 2 times, most recently from 48249a4 to 436748a Compare September 5, 2023 23:32
@Artturin Artturin marked this pull request as ready for review September 5, 2023 23:47
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is commented for llvm 16, git still uses 15

@Artturin
Copy link
Member Author

Artturin commented Sep 6, 2023

Everything builds

nixpkgs-review pr 253533 --package-regex llvmPackages -c commit

@Artturin Artturin merged commit 872e54e into NixOS:staging Sep 6, 2023
@Artturin Artturin deleted the llvmusesuball branch September 6, 2023 18:17
@rrbutani rrbutani added the 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants