Skip to content

nodejs: remove references to build dependencies#253156

Merged
marsam merged 1 commit intoNixOS:stagingfrom
SuperSandro2000:nodejs
Feb 27, 2024
Merged

nodejs: remove references to build dependencies#253156
marsam merged 1 commit intoNixOS:stagingfrom
SuperSandro2000:nodejs

Conversation

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Sep 3, 2023 •
edited
Loading

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment label Sep 3, 2023
@SuperSandro2000 SuperSandro2000 changed the base branch from master to staging September 3, 2023 16:35
@SuperSandro2000 SuperSandro2000 force-pushed the nodejs branch 2 times, most recently from dd389f4 to 82fb8c9 Compare September 3, 2023 17:22
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. labels Sep 3, 2023
@SuperSandro2000 SuperSandro2000 marked this pull request as ready for review January 14, 2024 18:03
@ofborg ofborg bot added 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. and removed 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. labels Jan 14, 2024
@SuperSandro2000
Copy link
Member Author

SuperSandro2000 commented Feb 27, 2024

@marsam can you take a look please?

marsam
marsam approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@marsam marsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@marsam marsam merged commit f268bc1 into NixOS:staging Feb 27, 2024
@tie
Copy link
Member

tie commented Feb 28, 2024 •
edited
Loading

@marsam @SuperSandro2000 doesn’t nuke-refs also remove dynamic loader reference? 😬

$ file /nix/store/ip600n5nk8k1j8kkjwbh35qqg4frkwri-nodejs-20.11.1/bin/node
/nix/store/ip600n5nk8k1j8kkjwbh35qqg4frkwri-nodejs-20.11.1/bin/node: ELF 64-bit LSB executable, x86-64, version 1 (GNU/Linux), dynamically linked, interpreter /nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-glibc-2.38-44/lib/ld-linux-x86-64.so.2, for GNU/Linux 3.10.0, not stripped

@tie tie mentioned this pull request Feb 28, 2024
Merged
13 tasks
@SuperSandro2000 SuperSandro2000 deleted the nodejs branch February 28, 2024 08:42
@SuperSandro2000
Copy link
Member Author

SuperSandro2000 commented Feb 28, 2024

🤔 that's a problem. Let me turn that into removeReferencesTo

@SuperSandro2000
Copy link
Member Author

SuperSandro2000 commented Feb 28, 2024

This is trickier than I thought. You can follow my progress at #292098. If I can't fix it today, we revert it.

@SuperSandro2000 SuperSandro2000 mentioned this pull request Feb 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cillianderoiste cillianderoiste Awaiting requested review from cillianderoiste

@gilligan gilligan Awaiting requested review from gilligan

@cko cko Awaiting requested review from cko

1 more reviewer

@marsam marsam marsam approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SuperSandro2000 @tie @marsam