Skip to content

Comments

[Backport release-23.05] [RFC 140] Simple package paths, part 1a: Checking tool#252154

Merged
infinisil merged 3 commits intorelease-23.05from
backport-250885-to-release-23.05
Aug 30, 2023
Merged

[Backport release-23.05] [RFC 140] Simple package paths, part 1a: Checking tool#252154
infinisil merged 3 commits intorelease-23.05from
backport-250885-to-release-23.05

Conversation

@github-actions
Copy link
Contributor

Bot-based backport to release-23.05, triggered by a label in #250885.

  • Before merging, ensure that this backport complies with the Criteria for Backporting.
    • Even as a non-commiter, if you find that it does not comply, leave a comment.

@github-actions github-actions bot requested a review from edolstra as a code owner August 29, 2023 14:36
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Aug 29, 2023
Adds an internal CLI tool to verify Nixpkgs to conform to RFC 140.
See pkgs/test/nixpkgs-check-by-name/README.md for more information.

(cherry picked from commit 271eb02)

Had to downgrade some dependencies in the Cargo.lock so that it builds
with the older Rust version.
@infinisil infinisil force-pushed the backport-250885-to-release-23.05 branch from 1f8137f to 17532e1 Compare August 29, 2023 15:14
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: policy discussion Discuss policies to work in and around Nixpkgs labels Aug 29, 2023
@infinisil
Copy link
Member

@ofborg build tests.nixpkgs-check-by-name

@infinisil
Copy link
Member

@infinisil
Copy link
Member

Cannot be merged like this just yet: #250885 (comment)

- Better filesystem case-sensitivity heuristic
  We shouldn't assume that Linux is always case-sensitive.
- Don't include case-sensitive filename in tree
  Was used for tests, but this broke channel updates because there's a
  check to make sure there's no case-sensitive files!

  https://hydra.nixos.org/build/233371356/nixlog/1

(cherry picked from commit d42ae66)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: policy discussion Discuss policies to work in and around Nixpkgs 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant