Skip to content

python3Packages.numpy: use pytestCheckHook & disable failing tests#251923

Merged
FRidh merged 1 commit intoNixOS:stagingfrom
misuzu:numpy-32-bit-fix
Sep 19, 2023
Merged

python3Packages.numpy: use pytestCheckHook & disable failing tests#251923
FRidh merged 1 commit intoNixOS:stagingfrom
misuzu:numpy-32-bit-fix

Conversation

@misuzu
Copy link
Contributor

@misuzu misuzu commented Aug 28, 2023

Description of changes

Closes: #251514

Things done

  • Built on platform(s)
    • x86_64-linux
    • i686-linux
    • armv7l-linux (native)
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 28, 2023
@ofborg ofborg bot requested a review from FRidh August 28, 2023 08:18
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 2501-5000 This PR causes many rebuilds on Darwin and should target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Aug 28, 2023
@misuzu misuzu requested a review from SuperSandro2000 August 28, 2023 08:45
SuperSandro2000
SuperSandro2000 reviewed Aug 28, 2023
View reviewed changes
SuperSandro2000
SuperSandro2000 requested changes Aug 28, 2023
View reviewed changes
@misuzu misuzu changed the title python3Packages.numpy: run pytest directly & disable failing tests on 32-bit platforms python3Packages.numpy: use pytestCheckHook & disable failing tests Aug 28, 2023
@misuzu misuzu requested a review from SuperSandro2000 August 28, 2023 12:13
tjni
tjni reviewed Aug 29, 2023
View reviewed changes
@misuzu misuzu requested a review from tjni August 29, 2023 10:30
SuperSandro2000
SuperSandro2000 reviewed Aug 30, 2023
View reviewed changes
@misuzu misuzu requested a review from SuperSandro2000 August 31, 2023 05:39
SuperSandro2000
SuperSandro2000 approved these changes Sep 1, 2023
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lovely, thanks for bearing with us

@misuzu misuzu requested a review from vcunat September 6, 2023 06:32
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Sep 6, 2023
@nixos-discourse
Copy link

nixos-discourse commented Sep 18, 2023

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/2666

@FRidh FRidh merged commit 6ce133d into NixOS:staging Sep 19, 2023
@doronbehar
Copy link
Contributor

doronbehar commented Sep 20, 2023

Hey all, I was proposing a similar change in #255607 , for Numpy and Scipy. I have there now 1 small additional follow-up change to numpy, and another, similar commit for Scipy. I'd be interested to get your review at #255607 and your comments if you have any at #255262 .

@doronbehar doronbehar mentioned this pull request Sep 21, 2023
Open
13 tasks
@doronbehar doronbehar mentioned this pull request Sep 29, 2023
Closed
doronbehar added a commit to doronbehar/nixpkgs that referenced this pull request Oct 1, 2023
@doronbehar
python3.pkgs.numpy: use pytestCheckHook
7d77a5c 
Related to: NixOS#255262 and a
follow-up to NixOS#251923 :

- The NOSE_EXCLUDE environment variable was removed due to being
  unneeded, as upstream uses pytest for a long time now, and that
  disabled test was removed since.
- Support parallel testing with pytest-xdist
@misuzu misuzu deleted the numpy-32-bit-fix branch February 23, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@tjni tjni Awaiting requested review from tjni

@vcunat vcunat Awaiting requested review from vcunat

@mweinelt mweinelt Awaiting requested review from mweinelt

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 2501-5000 This PR causes many rebuilds on Darwin and should target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@misuzu @nixos-discourse @doronbehar @tjni @SuperSandro2000 @FRidh @wegank