python3Packages.flet: fix out of the box experience#251877
python3Packages.flet: fix out of the box experience#251877lucasew wants to merge 9 commits intoNixOS:masterfrom
Conversation
Signed-off-by: lucasew <[email protected]>
Signed-off-by: lucasew <[email protected]>
Signed-off-by: lucasew <[email protected]>
Signed-off-by: lucasew <[email protected]>
github-actions
bot
added
the
6.topic: python
|
Result of 6 packages built:
|
|
How to test: There are many examples here: https://github.com/flet-dev/examples I still need to test if scripts with external modules works nice, like something with numpy idk. |
There was a problem hiding this comment.
Please don't, if this is an issue for you use something like nix-update that will properly update the version and hash at the same time.
There was a problem hiding this comment.
In this case it's important that the client bumps together with the python module so I am using the python module version to get which revision will be used to build the client. This would only be a reminder to update the hash of the client too when bumping.
There was a problem hiding this comment.
Don't make a package to be dependent on another one version since this tends to cause a multitude of other issues.
Better to keep both of them separate and add a comment for the maintainer to update both at the same time.
There was a problem hiding this comment.
Solved
I am now using the src from the flutter program as base. When the flutter program is updated both python libraries are updated by consequence.
There was a problem hiding this comment.
And I think I broke the patch lol
Signed-off-by: lucasew <[email protected]>
…let{,-core}
Signed-off-by: lucasew <[email protected]>
Signed-off-by: lucasew <[email protected]>
Signed-off-by: lucasew <[email protected]>
lucasew
force-pushed
the
fix-flet
branch
2 times, most recently
from
7168ddb to
8a1305d
Compare
|
Result of 10 packages built:
|
|
Just tried a quick PoC to check about external libraries support. The package is also not up to date, I tried bumping it but I think it's better to solve this on a follow up PR. |
Signed-off-by: lucasew <[email protected]>
|
Fix the failures |
|
Moved to #279936 |
3 participants
Description of changes
Without this PR flet gives an error about missing some binary in HOME, that's because the Python library does some kind of RPC to a GUI app made in flutter.
This PR solves this issue by packaging the GUI app and patching the library so it works out of the box.
Web still doesn't work because
buildFlutterApplicationdon't allow trivially creating web builds yet.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)