Merged
Conversation
Merged
12 tasks
Artturin
force-pushed
the
gccfixes1
branch
2 times, most recently
from
19556d2 to
35c36a3
Compare
Artturin
changed the title
ofborg
bot
added
10.rebuild-linux-stdenv
Artturin
commented
Aug 27, 2023
Member
Author
There was a problem hiding this comment.
@marius851000 I guess you meant
Suggested change
| if [ "!${filesDone[$1]+a}" ]; then filesDone[$1]=a ; fi | |
| if [ ! "${filesDone[$1]+a}" ]; then filesDone[$1]=a ; fi |
here and below?
Member
Author
There was a problem hiding this comment.
@brano543 said the shellcheck commit broke something, maybe this is the breaking part.
Member
Author
There was a problem hiding this comment.
you can apply the shellcheck commit to your PR https://github.com/NixOS/nixpkgs/commit/25d7d273ddc2f3ce218bb8f24aaa763aedbc62b4.patch
Artturin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Non python non hook changes from #227818
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)