qutebrowser: 2.5.4 -> 3.0.0#251667
Closed
Conversation
ghost
requested review from
ghost
mentioned this pull request
12 tasks
github-actions
bot
added
6.topic: stdenv
ghost
mentioned this pull request
added 2 commits
August 26, 2023 14:04
ofborg
bot
added
10.rebuild-darwin: 1-10
rnhmjoj
requested changes
Aug 27, 2023
Contributor
rnhmjoj
left a comment
rnhmjoj
left a comment
There was a problem hiding this comment.
Why are you keeping the version at 2.5.4? 3.0.0 still supports Qt5, despite being advised against. Also QtWebKit is no longer supported and must be removed.
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This is the commit which should have been submitted as #250171.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)