python3.pkgs.detectron2: fix build#251151
Merged
fabaff merged 1 commit intoNixOS:masterfrom Aug 24, 2023
Merged
Conversation
github-actions
bot
added
the
6.topic: python
benxiao
force-pushed
the
rx/detectron-fix-build
branch
from
1dcb055 to
cb2a99a
Compare
ofborg
bot
added
10.rebuild-darwin: 1-10
Member
|
@ofborg build python310Packages.detectron2 |
Member
|
Result of 8 packages built:
|
Contributor
|
I just checked and the build is working on linux-x86_64 without this change. |
Contributor
Author
|
@happysalada the building of c extension is failing to due to missing pybind11. in torch derivation, USE_BIND11 is recently changed to USE_PYBIND11. and the comment above the change said it prevents pybind11 from leaking. so from now on , detectron2 need to explicitly add pybind11 to your buildinputs. instead of using pybind11 implicitly came from torch. I believe that's for all platforms. |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)