Skip to content

Comments

citron: init at 0.15.0#250939

Merged
AndersonTorres merged 2 commits intoNixOS:masterfrom
VuiMuich:add/citron
Aug 28, 2023
Merged

citron: init at 0.15.0#250939
AndersonTorres merged 2 commits intoNixOS:masterfrom
VuiMuich:add/citron

Conversation

@VuiMuich
Copy link
Contributor

@VuiMuich VuiMuich commented Aug 23, 2023

Description of changes

citron is a tool to send sytemdata (like battery, backlight or memory) via dbust to a notification daemon.
https://git.sr.ht/~grtcdr/citron

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 24, 2023
@h7x4
Copy link
Member

h7x4 commented Aug 24, 2023

Result of nixpkgs-review pr 250939 run on x86_64-linux 1

1 package built:
  • citorn

h7x4
h7x4 reviewed Aug 24, 2023
View reviewed changes
h7x4
h7x4 approved these changes Aug 24, 2023
View reviewed changes
Copy link
Member

@h7x4 h7x4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and ran binary. Seems to work fine. Nice!

@VuiMuich VuiMuich mentioned this pull request Aug 25, 2023
Merged
12 tasks
@VuiMuich
Copy link
Contributor Author

VuiMuich commented Aug 25, 2023

Built and ran binary. Seems to work fine. Nice!

Thanks for the reiew.

As per comment in #251335, I changed sha256 to hash and cargoSha256 to cargoHash as this seems to be preferred.

cafkafk
cafkafk requested changes Aug 25, 2023
View reviewed changes
Copy link
Member

@cafkafk cafkafk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I asked in the nixpkgs matrix room but they were slow too reply so I'll just drop it here and then if I'm wrong I'm sorry, but I'm pretty sure it would be best if you changed the order of your commits, so you first add yourself to the maintainers file, and then add the package.

@VuiMuich
Copy link
Contributor Author

VuiMuich commented Aug 25, 2023

I asked in the nixpkgs matrix room but they were slow too reply so I'll just drop it here and then if I'm wrong I'm sorry, but I'm pretty sure it would be best if you changed the order of your commits, so you first add yourself to the maintainers file, and then add the package.

Thanks to lazygit this was super simple 👍

Thanks for mentioning.

@cafkafk
Copy link
Member

cafkafk commented Aug 25, 2023

Result of nixpkgs-review pr 250939 run on x86_64-linux 1

1 package built:
  • citron

cafkafk
cafkafk approved these changes Aug 25, 2023
View reviewed changes
Copy link
Member

@cafkafk cafkafk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally on x86_64 GNU/Linux, binary built as expected, and shows help. Didn't test functionality of binary.

@nixos-discourse
Copy link

nixos-discourse commented Aug 25, 2023

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/2591

@nixos-discourse
Copy link

nixos-discourse commented Aug 25, 2023

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1070

AndersonTorres
AndersonTorres suggested changes Aug 25, 2023
View reviewed changes
AndersonTorres
AndersonTorres suggested changes Aug 25, 2023
View reviewed changes
@ofborg ofborg bot added the ofborg-internal-error Ofborg encountered an error label Aug 25, 2023
@AndersonTorres AndersonTorres removed the ofborg-internal-error Ofborg encountered an error label Aug 25, 2023
@AndersonTorres
Copy link
Member

AndersonTorres commented Aug 25, 2023

Ping me 2 days to merge

VuiMuich and others added 2 commits August 28, 2023 11:17
@VuiMuich
maintainers: add vuimuich
48fb3c6
@VuiMuich @AndersonTorres
citron: init at 0.15.0
aba1c99 
correct maintainer name

fix typo

change hash keys

Apply suggestions from code review

Co-authored-by: Anderson Torres <[email protected]>

Apply suggestions from code review

Co-authored-by: Anderson Torres <[email protected]>
@VuiMuich
Copy link
Contributor Author

VuiMuich commented Aug 28, 2023

@AndersonTorres here goes your ping.
Also I just rebased, idk how relevant or necessary it would be, but thought it wouldn't hurt either, right?

@AndersonTorres
Copy link
Member

AndersonTorres commented Aug 28, 2023

Way better.

@AndersonTorres AndersonTorres merged commit e45b9d1 into NixOS:master Aug 28, 2023
@VuiMuich VuiMuich deleted the add/citron branch August 28, 2023 12:02
@VuiMuich
Copy link
Contributor Author

VuiMuich commented Aug 28, 2023

Thanks for the merge!

@VuiMuich VuiMuich mentioned this pull request Sep 2, 2023
Merged
@devhell
Copy link
Contributor

devhell commented Sep 2, 2023

esult of nixpkgs-review pr 250939 run on x86_64-linux 1

1 package built:
  • citron

Tested binary, and works as expected (except citron network, but that might be due to my setup).

@VuiMuich
Copy link
Contributor Author

VuiMuich commented Sep 2, 2023

esult of nixpkgs-review pr 250939 run on x86_64-linux 1

1 package built: 
    <li>citron</li>

Tested binary, and works as expected (except citron network, but that might be due to my setup).

Thanks for testing.
I typically don't use the networking feature, but iirc, it requires the ability interface being defined in a config file placed in XDG_CONFIG_DIR.
Maybe it's worth to propose some sane fallback upstream, if no interface is configured.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@h7x4 h7x4 h7x4 approved these changes

@cafkafk cafkafk cafkafk approved these changes

+1 more reviewer

@AndersonTorres AndersonTorres AndersonTorres approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@VuiMuich @h7x4 @cafkafk @nixos-discourse @AndersonTorres @devhell