Merged
Conversation
tobim
force-pushed
the
pkgs/spdlog-1.12
branch
from
5eb8b0f to
8d1ba71
Compare
ofborg
bot
requested review from
SCOTT-HAMILTON,
alyssais,
babariviere,
obadz and
risicle
ofborg
bot
added
10.rebuild-darwin: 11-100
tobim
force-pushed
the
pkgs/spdlog-1.12
branch
from
8d1ba71 to
b5fc5b3
Compare
12 tasks
tobim
force-pushed
the
pkgs/spdlog-1.12
branch
from
b5fc5b3 to
5eba4b7
Compare
Contributor
Author
|
Result of 32 packages marked as broken and skipped:
22 packages failed to build:
179 packages built:
|
Contributor
Author
|
From the build failures, only irods is caused by this bump, the others seem to be unrelated failing tests. Fixing irods seems to be rather involved, and a bump and some cleanup would be very helpful. @bzizou would be available to help with that? |
Contributor
Author
|
I just discovered that |
Contributor
Author
|
@doronbehar & @marsam, may I ask you for a review? |
doronbehar
reviewed
Sep 1, 2023
Contributor
doronbehar
left a comment
doronbehar
left a comment
There was a problem hiding this comment.
Thanks for all the work! Pretty much the same review comment multiplied.
pkgs/applications/networking/instant-messengers/nheko/default.nix
Outdated
Show resolved
Hide resolved
tobim
force-pushed
the
pkgs/spdlog-1.12
branch
from
5eba4b7 to
ae1831a
Compare
doronbehar
reviewed
Sep 2, 2023
pkgs/applications/networking/instant-messengers/nheko/default.nix
Outdated
Show resolved
Hide resolved
Contributor
Hi. Just back from holiday, sorry. I can try to upgrade irods packages. Should I wait for this PR to be merged before? |
Contributor
Author
It can be fixed independently. |
tobim
force-pushed
the
pkgs/spdlog-1.12
branch
2 times, most recently
from
cb73c16 to
904fd80
Compare
Contributor
|
Looks great now, but there are build failures according to ofborg. One of them is a patch to nheko failing to apply. |
tobim
force-pushed
the
pkgs/spdlog-1.12
branch
from
904fd80 to
6a90877
Compare
Contributor
Author
|
The or-tools failure is related to protobuf. The best way to solve this is to update to the latest version, but that is not trivial. |
Contributor
And have you touched protobuf in this PR? Or do you think I can find |
Contributor
Author
It is broken on master. I would link to it but hydra is down. |
Contributor
|
And what is the package that depends on `or-tools`? I mean, why is ofborg trying to build `or-tools`?
|
Contributor
Author
For openroad. |
Contributor
|
Then why did you bother to update openroad, and write patches for it, if one of it's dependencies is failing to build?
…On 5 September 2023 20:21:45 GMT+03:00, tobim ***@***.***> wrote:
> And what is the package that depends on `or-tools`? I mean, why is ofborg trying to build `or-tools`?
For openroad.
--
Reply to this email directly or view it on GitHub:
#250435 (comment)
You are receiving this because you were mentioned.
Message ID: ***@***.***>
|
Contributor
Author
|
Because it wasn't broken when I started this PR. I think adding the fix here makes the most sense. |
Contributor
|
I tried to run |
Contributor
I see, and I agree. |
Contributor
|
I think it's important to see a nixpkgs-review report for this. |
Contributor
|
Fixed irods package into #253632 |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
|
It could be that my machine is too weak to run all of these nixpkgs-review builds together, that's why so many of them failed... I'm still investigating. Someone else's |
Contributor
Author
|
Result of 42 packages marked as broken and skipped:
23 packages failed to build:
175 packages built:
|
Contributor
|
Interesting.. I wonder why |
marsam
approved these changes
Sep 10, 2023
delroth
added
the
12.approvals: 1
Contributor
Author
I think nixpkgs-review only reports on packages that are affected by the change. |
Contributor
|
Result of 42 packages marked as broken and skipped:
5 packages failed to build:
193 packages built:
|
Contributor
|
I ran: And indeed running |
Contributor
|
Thanks for all the work @tobim ! |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
https://github.com/gabime/spdlog/releases/tag/v1.12.0
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)