Skip to content

emacs: better glib-networking detection#249867

Merged
AndersonTorres merged 1 commit intoNixOS:masterfrom
atorres1985-contrib:emacs
Aug 18, 2023
Merged

emacs: better glib-networking detection#249867
AndersonTorres merged 1 commit intoNixOS:masterfrom
atorres1985-contrib:emacs

Conversation

@AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Aug 18, 2023

Fixes #249756

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@AndersonTorres AndersonTorres marked this pull request as ready for review August 18, 2023 02:15
@github-actions github-actions bot added the 6.topic: emacs Text editor label Aug 18, 2023
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 18, 2023
@AndersonTorres
Copy link
Member Author

AndersonTorres commented Aug 18, 2023

@ShivanshuKantPrasad can you please test this?

@ShivanshuKantPrasad
Copy link

ShivanshuKantPrasad commented Aug 18, 2023

Tested. Pages are loading properly now.
2023-08-18T16:25:00,108150267+05:30

@AndersonTorres
Copy link
Member Author

AndersonTorres commented Aug 18, 2023

Scary.

@AndersonTorres AndersonTorres merged commit 473e81e into NixOS:master Aug 18, 2023
@github-actions github-actions bot mentioned this pull request Aug 18, 2023
Merged
1 task
@github-actions
Copy link
Contributor

github-actions bot commented Aug 18, 2023

Successfully created backport PR for release-23.05:

@AndersonTorres AndersonTorres mentioned this pull request Aug 18, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adisbladis adisbladis Awaiting requested review from adisbladis

@lovek323 lovek323 Awaiting requested review from lovek323

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@Atemu Atemu Awaiting requested review from Atemu

@jwiegley jwiegley Awaiting requested review from jwiegley

Assignees

No one assigned

Labels

6.topic: emacs Text editor 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Dependency glib-networking missing in emacs29-pgtk package

2 participants

@AndersonTorres @ShivanshuKantPrasad