[WIP] Cross compilation changes, with enphasis on (haskell) GHC HEAD#24983
Closed
Ericson2314 wants to merge 1 commit intoNixOS:masterfrom
Closed
[WIP] Cross compilation changes, with enphasis on (haskell) GHC HEAD#24983Ericson2314 wants to merge 1 commit intoNixOS:masterfrom
Ericson2314 wants to merge 1 commit intoNixOS:masterfrom
Conversation
Ericson2314
added
2.status: work-in-progress
6.topic: cross-compilation
|
@Ericson2314, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @bgamari, @bjornfor, @LnL7 and @copumpkin to be potential reviewers. |
Contributor
|
I'm not in charge of merges, but I think this is too much in one go. I suggest cherry-picking the "fixed cross compilation" and version bump commits into a separate PR, then rebasing this branch onto that one, then finding parts of the remaining changes that touch packages outside of ghc and separating them likewise. Also extricate the changes to lib/ and stdenv/ into separate PRs, keeping the non-breaking changes from the ones that should have no impact on master. |
7 tasks
Member
Author
Ericson2314
force-pushed
the
cross-haskell
branch
from
01119cd to
59249b9
Compare
Member
Author
|
Closing cause I finally cleaned up the history :D, but better to use a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This is initially a dump of a bunch of fixes and improvement I did for cross compilation for work---quite accelerating the pace I originally had in mind to do on my own :). I did slap-dash merge to put something up here (which seems to already have a conflict...) mainly to get a view-able diff up for those asking me about this. Within the next 2 weeks I'll try to make more progress cleaning things up so this is in a reviewable and mergeable state---the prior work which makes this cleanable is now done as of today so time to get the ball rolling.
This doesn't quite subsume #21268 as that as some further hash-preserving cleanups (e.g. the "build wrappers" file), which aren't part of this. Once this is in, that should be easy to rebase.
I doubt there is a good way to farm out cleaning up git history, but if anyone want to give it a shot, I'd really, really appreciate.
CC @dmjio @bgamari @elitak @copumpkin
Things done
targetPlatform.config or ""needed).