Recursive type deprecation, again#248444
Draft
infinisil wants to merge 5 commits intoNixOS:masterfrom
Draft
Conversation
This reverts commit 5075a51. There's no option location in the lib.warn message, not even if you make it fail using NIX_ABORT_ON_WARN So let's revert the switch to lib.warn for now until a better solution is figured out
…ely"" This reverts commit a36e676. There was one report saying that this broke a configuration, but I cannot reproduce this: NixOS#99132 (comment) We should give this another go
github-actions
bot
added
6.topic: nixos
ofborg
bot
added
10.rebuild-darwin: 0
wegank
added
the
2.status: stale
wegank
added
the
2.status: merge conflict
stale
bot
removed
the
2.status: stale
wegank
added
the
2.status: stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Very drafty retry of the reverted #99132, switching back
stringto be deprecated usingdeprecationMessageWhile I could not reproduce any infinite recursion even with the original code as reported in #99132 (comment), the code can be improved a bunch to prevent that in any case.
Unfortunately a new
lib.types.fixis necessary to implement this correctly, and all current recursive types should switch to that instead.