Add myself as a code owner of the contributing documentation#248166
Add myself as a code owner of the contributing documentation#248166infinisil merged 2 commits intoNixOS:masterfrom
Conversation
I want to take ownership of this part of the documentation, especially with the cleanup in NixOS#245243. Doing so before that PR is merged also allows me to get notified about any potential future merge conflicts before they happen.
Was removed in f397309
github-actions
bot
added
the
6.topic: policy discussion
infinisil
changed the title
| /doc/contributing/contributing-to-documentation.chapter.md @jtojnar @fricklerhandwerk | ||
| # Contributor documentation | ||
| /CONTRIBUTING.md @infinisil | ||
| /.github/PULL_REQUEST_TEMPLATE.md |
There was a problem hiding this comment.
Should this be /.github/PULL_REQUEST_TEMPLATE.md @infinisil?
There was a problem hiding this comment.
Oh damn yeah, sorry I merged it already, but I'll open a new one for that!
There was a problem hiding this comment.
Argh sorry, I should have been more careful. Also why does github say the file is valid with a basically empty entry?
There was a problem hiding this comment.
I guess it's not technically invalid, it just doesn't make much sense, I wouldn't mind them adding a check for that. It does have a slight effect though because codeowners of subdirectories override code owners of the parents.
There was a problem hiding this comment.
Because it actually is valid: A line with no owner is used to exclude a path from ownership.
# In this example, @octocat owns any file in the `/apps`
# directory in the root of your repository except for the `/apps/github`
# subdirectory, as its owners are left empty.
/apps/ @octocat
/apps/github
ofborg
bot
added
10.rebuild-darwin: 0
|
No need to wait for CI, and GitHub confirmed to me that
|
3 participants
I want to take ownership of this part of the documentation, especially with the cleanup in #245243. Doing so before that PR is merged also allows me to get notified about any potential future merge conflicts before they happen.