Skip to content

remnote: added myself to maintainers#248028

Merged
NickCao merged 2 commits intoNixOS:masterfrom
chewblacka:master-2
Aug 13, 2023
Merged

remnote: added myself to maintainers#248028
NickCao merged 2 commits intoNixOS:masterfrom
chewblacka:master-2

Conversation

@chewblacka
Copy link
Contributor

@chewblacka chewblacka commented Aug 8, 2023 •
edited
Loading

Description of changes

Added jgarcia to list of maintainers

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@chewblacka
maintainers: add jgarcia
42cb5fd 
Added jgarcia to list of maintainers
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Aug 8, 2023
@chewblacka chewblacka mentioned this pull request Aug 10, 2023
Closed
12 tasks
@chewblacka
remnote: added myself to maintainers
4b405d6 
Added myself (jgarcia) to list of maintainers for remnote
@chewblacka chewblacka changed the title maintainers: add jgarcia remnote: added myself to maintainers Aug 11, 2023
@tomodachi94 tomodachi94 added the 3.skill: trivial This is trivial to complete (typically find-and-replace) label Aug 11, 2023
tomodachi94
tomodachi94 approved these changes Aug 11, 2023
View reviewed changes
Copy link
Member

@tomodachi94 tomodachi94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@tomodachi94 tomodachi94 added the 12.approvals: 2 This PR was reviewed and approved by two persons. label Aug 11, 2023
@NickCao NickCao merged commit 9e6dd8a into NixOS:master Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomodachi94 tomodachi94 tomodachi94 approved these changes

+2 more reviewers

@fufexan fufexan fufexan approved these changes

@LudovicoPiero LudovicoPiero LudovicoPiero approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

3.skill: trivial This is trivial to complete (typically find-and-replace) 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@chewblacka @fufexan @LudovicoPiero @tomodachi94 @NickCao