I don't want to be a pain in the butt here or be offensive, but the commit and PR title do not match the contributing guidelines at all here, so I doubt that we should merge this.

Sorry OP, maybe you want to re-read the contributing guidelines and update this PR accordingly?

I don't want to be a pain in the butt here or be offensive, but the commit and PR title do not match the contributing guidelines at all here, so I doubt that we should merge this.

Sorry OP, maybe you want to re-read the contributing guidelines and update this PR accordingly?

Hi many thanks for the reply. If you could give me some guidance on what PR title and commit would be appropriate to add myself to the maintainers list I'd be very grateful. As far as I can work out the CONTRIBUTING.md only mentions package changes, not adding to the maintainer list. Apologies if I've missed something obvious!

If you have a look at the log of the file (git log --oneline -- maintainers/maintainer-list.nix), you'll see that commonly the commit message is maintainers: add <username>. That'd be a perfect PR title in this case as well.

If you have a look at the log of the file (git log --oneline -- maintainers/maintainer-list.nix), you'll see that commonly the commit message is maintainers: add <username>. That'd be a perfect PR title in this case as well.

Much obliged! I have amended the title. Thanks again.

Yes, please also fix the commit title, that'd be much appreciated!

As far as I can work out the CONTRIBUTING.md only mentions package changes, not adding to the maintainer list. Apologies if I've missed something obvious!

You didn't miss anything. I don't think it's mentioned in there. It's in the manual though.

Yes, please also fix the commit title, that'd be much appreciated!

I'm just going to close this and submit a new request as it's way easier.

That's not necessary, just git commit --amend the commit you pushed here and git push this with a little bit of --force.

That's not necessary, just git commit --amend the commit you pushed here and git push this with a little bit of --force.

Thanks, next time I'll use the above method. In the mean time I've created a new pull request here: #248028