Conversation
roberth
left a comment
There was a problem hiding this comment.
Indeed none of these look like they should ever be merged with string concatenation.
It is an error[1] now. [1]: NixOS#247848
ac2ab1a to
74fadae
Compare
|
Fixed the linked issue number in the commit message. |
|
Oof I'm a bit surprised these made it in at all, the type should throw a deprecation warning when used. Thanks for the fix! |
|
I am sorry for writing one of PRs that used one of these. Do these warnings not appear when building with 'nix build'? I had one in my branch for a while but never noticed any diagnostic output regarding this. |
|
@majiru They should definitely appear with both |
|
I only tested my PR with nixos-rebuild. I didn't see any warning. |
|
We had some of these lying around in nix-darwin and they did not throw up any warnings (otherwise I'd have fixed them earlier). I don't know why the warning wasn't working, but it seems like this went from being accepted without complaints directly to a hard error. Not a problem for us, but I just want to flag up that this could cause problems elsewhere in the ecosystem because of that. |
|
I opened a PR with a revert and a |
|
Hi any updates on removing the types.string deprecation error? I am just now getting into Nix and NIxOS ecosystem and I cannot rebuild my configuration due to multiple module/nixpkg references coming from this deprecated type error. Kindly advise. I see that the master branch has a PR with a fix that's been merged. How do I go about replicating the changes made across the master branch into my Nix machines? Apologies if this is a noob question. Should I use the unstable or stable channels? I noticed the Nix manual indicates that the master branch and channels have a few days of lag... |
|
@RyzeNGrind just wait a little and roll back your channel in the mean time. The fix will be in unstable in a few days at most. |
|
@Atemu Thank you for your response. Is there anyway I can hot patch this fix for now so I can keep working on my systems without the several day delay? Appreciate your help with this matter. Edit: Any advice on how to roll back the channel would be appreciated as well as it doesn't seem straightforward |
|
Maybe use |
|
You can just use |
|
Alternatively, you can also briefly switch to the nixos-unstable-small channel which already has the fix. That's more trouble than it's worth though IMO. This is a topic for a post on Discourse however, not this place. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
It is an error1 now.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)