bintools-wrapper: fix dynamic linker for powerpc64 big-endian#247682
Merged
Artturin merged 1 commit intoNixOS:masterfrom Sep 11, 2023
Merged
bintools-wrapper: fix dynamic linker for powerpc64 big-endian#247682Artturin merged 1 commit intoNixOS:masterfrom
Artturin merged 1 commit intoNixOS:masterfrom
Conversation
13 tasks
OPNA2608
reviewed
Sep 3, 2023
4 tasks
1910d13 to
5581c06
Compare
OPNA2608
approved these changes
Sep 11, 2023
Contributor
OPNA2608
left a comment
There was a problem hiding this comment.
Tested by cross-compiling hello for powerpc64-unknown-linux-gnuabielfv1 & powerpc64-unknown-linux-gnuabielfv2, copying the closures to my powerpc64-linux machine and executing both there: Works fine.
Contributor
|
Successfully created backport PR for |
Merged
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This fixes #245162.
I also tested this change in the same file:
Which is a partial revert of 238a605, which worked, but I don't know the use behind that change (@Artturin) so I'm just proposing this quick fix.
Here's the test file I'm using:
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)